From 5273c469d8fa81cbbef232876a93117a3009e61b Mon Sep 17 00:00:00 2001 From: "Dominik Schilling (ocean90)" Date: Fri, 30 Sep 2016 13:12:00 +0000 Subject: [PATCH] Add test for each whitelisted URI protocol in `wp_allowed_protocols()`. Move test from [25301] to the new file. Fixes #38198. git-svn-id: https://develop.svn.wordpress.org/trunk@38685 602fd350-edb4-49c9-b593-d223f7449a82 --- tests/phpunit/tests/functions.php | 7 --- .../tests/functions/allowedProtocols.php | 61 +++++++++++++++++++ 2 files changed, 61 insertions(+), 7 deletions(-) create mode 100644 tests/phpunit/tests/functions/allowedProtocols.php diff --git a/tests/phpunit/tests/functions.php b/tests/phpunit/tests/functions.php index 13a0ff4726..f520967f27 100644 --- a/tests/phpunit/tests/functions.php +++ b/tests/phpunit/tests/functions.php @@ -501,13 +501,6 @@ class Tests_Functions extends WP_UnitTestCase { ); } - /** - * @ticket 19354 - */ - function test_data_is_not_an_allowed_protocol() { - $this->assertNotContains( 'data', wp_allowed_protocols() ); - } - /** * @ticket 9064 */ diff --git a/tests/phpunit/tests/functions/allowedProtocols.php b/tests/phpunit/tests/functions/allowedProtocols.php new file mode 100644 index 0000000000..77c04d4522 --- /dev/null +++ b/tests/phpunit/tests/functions/allowedProtocols.php @@ -0,0 +1,61 @@ +assertNotContains( 'data', wp_allowed_protocols() ); + } + + function test_allowed_protocol_has_an_example() { + $example_protocols = array(); + foreach ( $this->data_example_urls() as $example ) { + $example_protocols[] = $example[0]; + } + $this->assertEqualSets( $example_protocols, wp_allowed_protocols() ); + } + + /** + * @depends test_allowed_protocol_has_an_example + * @dataProvider data_example_urls + * + * @param string The scheme. + * @param string Example URL. + */ + function test_allowed_protocols( $protocol, $url ) { + $this->assertEquals( $url, esc_url( $url, $protocol ) ); + $this->assertEquals( $url, esc_url( $url, wp_allowed_protocols() ) ); + } + + /** + * @link http://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml + */ + function data_example_urls() { + return array( + array( 'http', 'http://example.com' ), // RFC7230 + array( 'https', 'http://example.com' ), // RFC7230 + array( 'ftp', 'ftp://example.com' ), // RFC1738 + array( 'ftps', 'ftps://example.com' ), + array( 'mailto', 'mailto://someone@example.com' ), // RFC6068 + array( 'news', 'news://news.server.example/example.group.this' ), // RFC5538 + array( 'irc', 'irc://example.com/wordpress' ), + array( 'gopher', 'gopher://example.com/7a_gopher_selector%09foobar' ), // RFC4266 + array( 'nntp', 'nntp://news.server.example/example.group.this' ), // RFC5538 + array( 'feed', 'feed://example.com/rss.xml' ), + array( 'telnet', 'telnet://user:password@example.com:80/' ), // RFC4248 + array( 'mms', 'mms://example.com:80/path' ), + array( 'rtsp', 'rtsp://media.example.com:554/wordpress/audiotrack' ), // RFC2326 + array( 'svn', 'svn://core.svn.wordpress.org/' ), + array( 'tel', 'tel:+1-234-567-8910' ), // RFC3966 + array( 'fax', 'fax:+123.456.78910' ), // RFC2806/RFC3966 + array( 'xmpp', 'xmpp://guest@example.com' ), // RFC5122 + array( 'webcal', 'webcal://example.com/calendar.ics' ), + ); + } +}