sergiotarxz/Wordpress
sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

XMLRPC: Restore support in wp.newPost for dates to be supplied in the structured dateTime.iso8601 format as well as still supporting dates specified as strings.

Browse Source 
Fixes #28601.


git-svn-id: https://develop.svn.wordpress.org/trunk@29063 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Peter Westwood 2014-07-10 14:16:20 +00:00
parent c89afd5a59
commit 52aa1804e4
2 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/wp-includes/class-wp-xmlrpc-server.php
View File

@ -1103,13 +1103,13 @@ class wp_xmlrpc_server extends IXR_Server {
return $this->error;
// convert the date field back to IXR form
if ( isset( $content_struct['post_date'] ) ) {
if ( isset( $content_struct['post_date'] ) && ! is_a( $content_struct['post_date'], 'IXR_Date' ) ) {
$content_struct['post_date'] = $this->_convert_date( $content_struct['post_date'] );
}
// ignore the existing GMT date if it is empty or a non-GMT date was supplied in $content_struct,
// since _insert_post will ignore the non-GMT date if the GMT date is set
if ( isset( $content_struct['post_date_gmt'] ) ) {
if ( isset( $content_struct['post_date_gmt'] ) && ! is_a( $content_struct['post_date_gmt'], 'IXR_Date' ) ) {
if ( $content_struct['post_date_gmt'] == '0000-00-00 00:00:00' || isset( $content_struct['post_date'] ) ) {
unset( $content_struct['post_date_gmt'] );
} else {

26
tests/phpunit/tests/xmlrpc/wp/newPost.php
View File

@ -357,4 +357,30 @@ class Tests_XMLRPC_wp_newPost extends WP_XMLRPC_UnitTestCase {
$this->assertEquals( $date_string , $fetched_post->post_date_gmt );
}
/**
* @ticket 28601
*/
function test_valid_IXR_post_date() {
$this->make_user_by_role( 'author' );
$date_string = '1984-01-11 05:00:00';
$post = array( 'post_title' => 'test', 'post_content' => 'test', 'post_date' => new IXR_Date( mysql2date( 'Ymd\TH:i:s', $date_string, false ) ) );
$result = $this->myxmlrpcserver->wp_newPost( array( 1, 'author', 'author', $post ) );
$fetched_post = get_post( $result );
$this->assertStringMatchesFormat( '%d', $result );
$this->assertEquals( $date_string , $fetched_post->post_date );
}
/**
* @ticket 28601
*/
function test_valid_IXR_post_date_gmt() {
$this->make_user_by_role( 'author' );
$date_string = '1984-01-11 05:00:00';
$post = array( 'post_title' => 'test', 'post_content' => 'test', 'post_date_gmt' => new IXR_Date( mysql2date( 'Ymd\TH:i:s', $date_string, false ) ) );
$result = $this->myxmlrpcserver->wp_newPost( array( 1, 'author', 'author', $post ) );
$fetched_post = get_post( $result );
$this->assertStringMatchesFormat( '%d', $result );
$this->assertEquals( $date_string , $fetched_post->post_date_gmt );
}
}