sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

REST API: Remove redundant "0" parameter.

Browse Source 
This is just an artifact of how we parse the URL, and is already available
via $request->get_route()

Props danielbachhuber.
Fixes #34647.


git-svn-id: https://develop.svn.wordpress.org/trunk@35659 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Ryan McCue 2015-11-18 07:23:38 +00:00
parent 7b12240b12
commit 52bdf9d6a5
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-includes/rest-api/class-wp-rest-server.php
View File

@ -789,6 +789,8 @@ class WP_REST_Server {
} }
if ( ! is_wp_error( $response ) ) { if ( ! is_wp_error( $response ) ) {
// Remove the redundant preg_match argument.
unset( $args[0] );
$request->set_url_params( $args ); $request->set_url_params( $args );
$request->set_attributes( $handler ); $request->set_attributes( $handler );

15
tests/phpunit/tests/rest-api/rest-server.php
View File

@ -106,6 +106,21 @@ class Tests_REST_Server extends WP_Test_REST_TestCase {
$this->assertArrayNotHasKey( 'foo', (array) $request ); $this->assertArrayNotHasKey( 'foo', (array) $request );
} }
public function test_no_zero_param() {
register_rest_route( 'no-zero', '/test', array(
'methods' => array( 'GET' ),
'callback' => '__return_null',
'args' => array(
'foo' => array(
'default' => 'bar',
),
),
) );
$request = new WP_REST_Request( 'GET', '/no-zero/test' );
$this->server->dispatch( $request );
$this->assertEquals( array( 'foo' => 'bar' ), $request->get_params() );
}
/** /**
* Pass a capability which the user does not have, this should * Pass a capability which the user does not have, this should
* result in a 403 error. * result in a 403 error.