From 5b7baae9078d1f00c7fcf65b94954635af55db89 Mon Sep 17 00:00:00 2001 From: Boone Gorges Date: Fri, 16 Jan 2015 21:36:12 +0000 Subject: [PATCH] In `get_edit_term_link()`, default to a valid `$object_type`. The $object_type param is used to set the 'post_type' query var, which determines the post type menu that will be expanded when clicking through to the term edit page. Not all taxonomies are associated with Posts, so it makes sense to default to a post_type that the taxonomy is actually associated with. Props DzeryCZ, juliobox. Fixes #29251. git-svn-id: https://develop.svn.wordpress.org/trunk@31218 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/link-template.php | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/wp-includes/link-template.php b/src/wp-includes/link-template.php index ae1224bd52..06ecc8f499 100644 --- a/src/wp-includes/link-template.php +++ b/src/wp-includes/link-template.php @@ -888,9 +888,10 @@ function edit_tag_link( $link = '', $before = '', $after = '', $tag = null ) { * * @since 3.1.0 * - * @param int $term_id Term ID - * @param string $taxonomy Taxonomy - * @param string $object_type The object type + * @param int $term_id Term ID. + * @param string $taxonomy Taxonomy. + * @param string $object_type The object type. Used to highlight the proper post type menu on the linked page. + * Defaults to the first object_type associated with the taxonomy. * @return string The edit term link URL for the given term. */ function get_edit_term_link( $term_id, $taxonomy, $object_type = '' ) { @@ -906,8 +907,11 @@ function get_edit_term_link( $term_id, $taxonomy, $object_type = '' ) { 'tag_ID' => $term->term_id, ); - if ( $object_type ) + if ( $object_type ) { $args['post_type'] = $object_type; + } else if ( ! empty( $tax->object_type ) ) { + $args['post_type'] = reset( $tax->object_type ); + } $location = add_query_arg( $args, admin_url( 'edit-tags.php' ) );