sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Customiser: Prevent JS errors when previewing pages with an `<area>` tag. 

The customiser assumes that `<area>` tags will have a `href` attribute, which isn't necessarily true. Now it checks instead of assuming.

Props janthiel, adamsilverstein.
Fixes #45053.



git-svn-id: https://develop.svn.wordpress.org/trunk@44684 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Gary Pendergast 2019-01-21 23:02:39 +00:00
parent d70c159c96
commit 5e77c07a2e
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/js/_enqueues/wp/customize/preview.js
View File

@ -237,7 +237,7 @@
* @returns {void} * @returns {void}
*/ */
api.addLinkPreviewing = function addLinkPreviewing() { api.addLinkPreviewing = function addLinkPreviewing() {
var linkSelectors = 'a[href], area'; var linkSelectors = 'a[href], area[href]';
// Inject links into initial document. // Inject links into initial document.
$( document.body ).find( linkSelectors ).each( function() { $( document.body ).find( linkSelectors ).each( function() {
@ -337,6 +337,11 @@
api.prepareLinkPreview = function prepareLinkPreview( element ) { api.prepareLinkPreview = function prepareLinkPreview( element ) {
var queryParams, $element = $( element ); var queryParams, $element = $( element );
// Skip elements with no href attribute. Check first to avoid more expensive checks down the road
if ( ! element.hasAttribute( 'href' ) ) {
return;
}
// Skip links in admin bar. // Skip links in admin bar.
if ( $element.closest( '#wpadminbar' ).length ) { if ( $element.closest( '#wpadminbar' ).length ) {
return; return;
@ -776,7 +781,7 @@
api.settings.changeset.uuid = uuid; api.settings.changeset.uuid = uuid;
// Update UUIDs in links and forms. // Update UUIDs in links and forms.
$( document.body ).find( 'a[href], area' ).each( function() { $( document.body ).find( 'a[href], area[href]' ).each( function() {
api.prepareLinkPreview( this ); api.prepareLinkPreview( this );
} ); } );
$( document.body ).find( 'form' ).each( function() { $( document.body ).find( 'form' ).each( function() {
@ -810,7 +815,7 @@
api.settings.changeset.autosaved = true; // Start deferring to any autosave once changeset is updated. api.settings.changeset.autosaved = true; // Start deferring to any autosave once changeset is updated.
$( document.body ).find( 'a[href], area' ).each( function() { $( document.body ).find( 'a[href], area[href]' ).each( function() {
api.prepareLinkPreview( this ); api.prepareLinkPreview( this );
} ); } );
$( document.body ).find( 'form' ).each( function() { $( document.body ).find( 'form' ).each( function() {