sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Multisite: Do not check for `is_super_admin()` when trying to set user settings. 

The checks were introduced in [22256] to prevent user settings to be set for super admins that were not a member of the current site. However the latter should apply to any kind of user, so the `is_super_admin()` check is redundant. Furthermore, removing these checks is necessary for the ongoing effort to get rid of `is_super_admin()` checks in general.

Props chandrapatel for initial patch.
Fixes #39199. See #37616.


git-svn-id: https://develop.svn.wordpress.org/trunk@39932 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Felix Arntz 2017-01-20 17:32:13 +00:00
parent c0926aa662
commit 60f3612684
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-admin/includes/dashboard.php
View File

@ -487,7 +487,7 @@ function wp_dashboard_quick_press( $error_msg = false ) {
$post = get_default_post_to_edit( 'post' , true);
$user_id = get_current_user_id();
// Don't create an option if this is a super admin who does not belong to this site.
if ( ! ( is_super_admin( $user_id ) && ! in_array( get_current_blog_id(), array_keys( get_blogs_of_user( $user_id ) ) ) ) )
if ( in_array( get_current_blog_id(), array_keys( get_blogs_of_user( $user_id ) ) ) )
update_user_option( $user_id, 'dashboard_quick_press_last_post_id', (int) $post->ID ); // Save post_ID
}

4
src/wp-includes/option.php
View File

@ -808,7 +808,7 @@ function wp_user_settings() {
return;
}
if ( is_super_admin() && ! is_user_member_of_blog() ) {
if ( ! is_user_member_of_blog() ) {
return;
}
@ -972,7 +972,7 @@ function wp_set_all_user_settings( $user_settings ) {
return false;
}
if ( is_super_admin() && ! is_user_member_of_blog() ) {
if ( ! is_user_member_of_blog() ) {
return;
}