From 63731a69239868352e354647f39ad3bcb39941f2 Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Mon, 12 Jun 2017 14:08:34 +0000 Subject: [PATCH] Accessibility: Avoid a keyboard trap on the permalink custom structure setting. Using the `focus` event on the permalink custom structure field made impossible to navigate through all the form fields using only the keyboard without actually selecting the custom structure setting. Instead, using click and input preserves the original functionality when using any kind of pointing or input device. Also changes `attr()` to `prop()`` as recommended for a `checked` property. Fixes #40982. git-svn-id: https://develop.svn.wordpress.org/trunk@40897 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/options.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wp-admin/includes/options.php b/src/wp-admin/includes/options.php index a085a4ad5c..6b8114d571 100644 --- a/src/wp-admin/includes/options.php +++ b/src/wp-admin/includes/options.php @@ -100,8 +100,8 @@ jQuery(document).ready(function() { return; jQuery('#permalink_structure').val( this.value ); }); - jQuery('#permalink_structure').focus(function() { - jQuery("#custom_selection").attr('checked', 'checked'); + jQuery( '#permalink_structure' ).on( 'click input', function() { + jQuery( '#custom_selection' ).prop( 'checked', true ); }); });