Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses.

Props SergeyBiryukov.
See #28843 and [28583].


git-svn-id: https://develop.svn.wordpress.org/trunk@29118 602fd350-edb4-49c9-b593-d223f7449a82

src/wp-admin/includes/class-wp-links-list-table.php

@@ -75,7 +75,7 @@ class WP_Links_List_Table extends WP_List_Table {
 <?php
 	}
 
-	protected function get_columns() {
+	public function get_columns() {
 		return array(
 			'cb'         => '<input type="checkbox" />',
 			'name'       => _x( 'Name', 'link name' ),

src/wp-admin/includes/class-wp-list-table.php

@@ -538,11 +538,11 @@ class WP_List_Table {
 	 * Get the current page number
 	 *
 	 * @since 3.1.0
-	 * @access protected
+	 * @access public
 	 *
 	 * @return int
 	 */
-	protected function get_pagenum() {
+	public function get_pagenum() {
 		$pagenum = isset( $_REQUEST['paged'] ) ? absint( $_REQUEST['paged'] ) : 0;
 
 		if( isset( $this->_pagination_args['total_pages'] ) && $pagenum > $this->_pagination_args['total_pages'] )
@@ -675,12 +675,12 @@ class WP_List_Table {
 	 * 'internal-name' => 'Title'
 	 *
 	 * @since 3.1.0
-	 * @access protected
+	 * @access public
 	 * @abstract
 	 *
 	 * @return array
 	 */
-	protected function get_columns() {
+	public function get_columns() {
 		die( 'function WP_List_Table::get_columns() must be over-ridden in a sub-class.' );
 	}
 

src/wp-admin/includes/class-wp-media-list-table.php

@@ -170,7 +170,7 @@ class WP_Media_List_Table extends WP_List_Table {
 <?php
 	}
 
-	protected function get_columns() {
+	public function get_columns() {
 		$posts_columns = array();
 		$posts_columns['cb'] = '<input type="checkbox" />';
 		$posts_columns['icon'] = '';

src/wp-admin/includes/class-wp-ms-sites-list-table.php

@@ -143,7 +143,7 @@ class WP_MS_Sites_List_Table extends WP_List_Table {
 			$this->view_switcher( $mode );
 	}
 
-	protected function get_columns() {
+	public function get_columns() {
 		$blogname_columns = ( is_subdomain_install() ) ? __( 'Domain' ) : __( 'Path' );
 		$sites_columns = array(
 			'cb'          => '<input type="checkbox" />',

src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -174,7 +174,7 @@ class WP_MS_Themes_List_Table extends WP_List_Table {
 			_e( 'You do not appear to have any themes available at this time.' );
 	}
 
-	protected function get_columns() {
+	public function get_columns() {
 		global $status;
 
 		return array(

src/wp-admin/includes/class-wp-ms-users-list-table.php

@@ -108,7 +108,7 @@ class WP_MS_Users_List_Table extends WP_List_Table {
 			$this->view_switcher( $mode );
 	}
 
-	protected function get_columns() {
+	public function get_columns() {
 		$users_columns = array(
 			'cb'         => '<input type="checkbox" />',
 			'username'   => __( 'Username' ),

src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -207,7 +207,7 @@ class WP_Plugin_Install_List_Table extends WP_List_Table {
 		return array( 'widefat', $this->_args['plural'] );
 	}
 
-	protected function get_columns() {
+	public function get_columns() {
 		return array(
 			'name'        => _x( 'Name', 'plugin name' ),
 			'version'     => __( 'Version' ),

src/wp-admin/includes/class-wp-plugins-list-table.php

@@ -210,7 +210,7 @@ class WP_Plugins_List_Table extends WP_List_Table {
 			_e( 'You do not appear to have any plugins available at this time.' );
 	}
 
-	protected function get_columns() {
+	public function get_columns() {
 		global $status;
 
 		return array(

src/wp-admin/includes/class-wp-posts-list-table.php

@@ -264,7 +264,7 @@ class WP_Posts_List_Table extends WP_List_Table {
 		return array( 'widefat', 'fixed', is_post_type_hierarchical( $this->screen->post_type ) ? 'pages' : 'posts' );
 	}
 
-	protected function get_columns() {
+	public function get_columns() {
 		$post_type = $this->screen->post_type;
 
 		$posts_columns = array();

src/wp-admin/includes/class-wp-terms-list-table.php

@@ -116,7 +116,7 @@ class WP_Terms_List_Table extends WP_List_Table {
 		return parent::current_action();
 	}
 
-	protected function get_columns() {
+	public function get_columns() {
 		$columns = array(
 			'cb'          => '<input type="checkbox" />',
 			'name'        => _x( 'Name', 'term name' ),

src/wp-admin/includes/class-wp-themes-list-table.php

@@ -110,7 +110,7 @@ class WP_Themes_List_Table extends WP_List_Table {
 <?php
 	}
 
-	protected function get_columns() {
+	public function get_columns() {
 		return array();
 	}