sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

REST API: Allow parent property to be explicitly set to 0 when creating or updating a Post.

Browse Source 
Props lucasstark, danielbachhuber.
Fixes #38852.

git-svn-id: https://develop.svn.wordpress.org/trunk@39289 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Rachel Baker 2016-11-18 18:11:49 +00:00
parent ff38fc46e4
commit 659822098a
2 changed files with 44 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php
View File

@ -991,14 +991,16 @@ class WP_REST_Posts_Controller extends WP_REST_Controller {
} }
// Parent. // Parent.
if ( ! empty( $schema['properties']['parent'] ) && ! empty( $request['parent'] ) ) { if ( ! empty( $schema['properties']['parent'] ) && isset( $request['parent'] ) ) {
$parent = get_post( (int) $request['parent'] ); if ( 0 === (int) $request['parent'] ) {
$prepared_post->post_parent = 0;
if ( empty( $parent ) ) { } else {
return new WP_Error( 'rest_post_invalid_id', __( 'Invalid post parent ID.' ), array( 'status' => 400 ) ); $parent = get_post( (int) $request['parent'] );
if ( empty( $parent ) ) {
return new WP_Error( 'rest_post_invalid_id', __( 'Invalid post parent ID.' ), array( 'status' => 400 ) );
}
$prepared_post->post_parent = (int) $parent->ID;
} }
$prepared_post->post_parent = (int) $parent->ID;
} }
// Menu order. // Menu order.

35
tests/phpunit/tests/rest-api/rest-pages-controller.php
View File

@ -371,6 +371,41 @@ class WP_Test_REST_Pages_Controller extends WP_Test_REST_Post_Type_Controller_Te
$this->assertEquals( 0, $new_data['menu_order'] ); $this->assertEquals( 0, $new_data['menu_order'] );
} }
public function test_update_page_parent_non_zero() {
$page_id1 = $this->factory->post->create( array(
'post_type' => 'page',
) );
$page_id2 = $this->factory->post->create( array(
'post_type' => 'page',
) );
wp_set_current_user( self::$editor_id );
$request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/pages/%d', $page_id2 ) );
$request->set_body_params( array(
'parent' => $page_id1,
) );
$response = $this->server->dispatch( $request );
$new_data = $response->get_data();
$this->assertEquals( $page_id1, $new_data['parent'] );
}
public function test_update_page_parent_zero() {
$page_id1 = $this->factory->post->create( array(
'post_type' => 'page',
) );
$page_id2 = $this->factory->post->create( array(
'post_type' => 'page',
'post_parent' => $page_id1,
) );
wp_set_current_user( self::$editor_id );
$request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/pages/%d', $page_id2 ) );
$request->set_body_params( array(
'parent' => 0,
) );
$response = $this->server->dispatch( $request );
$new_data = $response->get_data();
$this->assertEquals( 0, $new_data['parent'] );
}
public function test_get_page_with_password() { public function test_get_page_with_password() {
$page_id = $this->factory->post->create( array( $page_id = $this->factory->post->create( array(
'post_type' => 'page', 'post_type' => 'page',