sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Posts, Post Types: Allow support arguments to be specified when registering post types.

Browse Source 
The `add_post_type_support()` function accepts an optional third parameter that allows extra arguments to be supplied to configure post type support for a given feature. However, because of how `register_post_type()` and `WP_Post_Type->add_supports()` work, it is currently impossible to pass these additional arguments when initially registering a post type with `register_post_type()`.

This change makes it possible to supply additional arguments for a feature using the `supports` argument of `register_post_type()`.

Props MaximeCulea, seuser, desrosj, johnbillion.
Fixes #40413.

git-svn-id: https://develop.svn.wordpress.org/trunk@46160 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jonathan Desrosiers 2019-09-17 19:57:18 +00:00
parent 5e38f8219b
commit 65ec280a54
2 changed files with 48 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/wp-includes/class-wp-post-type.php
View File

@ -513,7 +513,13 @@ final class WP_Post_Type {
*/ */
public function add_supports() { public function add_supports() {
if ( ! empty( $this->supports ) ) { if ( ! empty( $this->supports ) ) {
add_post_type_support( $this->name, $this->supports ); foreach ( $this->supports as $feature => $args ) {
if ( is_array( $args ) ) {
add_post_type_support( $this->name, $feature, $args );
} else {
add_post_type_support( $this->name, $args );
}
}
unset( $this->supports ); unset( $this->supports );
} elseif ( false !== $this->supports ) { } elseif ( false !== $this->supports ) {
// Add default features. // Add default features.

41
tests/phpunit/tests/post/wpPostType.php
View File

@ -62,6 +62,47 @@ class Tests_WP_Post_Type extends WP_UnitTestCase {
$this->assertEqualSets( array(), $post_type_supports_after ); $this->assertEqualSets( array(), $post_type_supports_after );
} }
/**
* Test that supports can optionally receive nested args.
*
* @ticket 40413
*/
public function test_add_supports_custom_with_args() {
$post_type = 'cpt';
$post_type_object = new WP_Post_Type(
$post_type,
array(
'supports' => array(
'support_with_args' => array(
'arg1',
'arg2',
),
'support_without_args',
),
)
);
$post_type_object->add_supports();
$post_type_supports = get_all_post_type_supports( $post_type );
$post_type_object->remove_supports();
$post_type_supports_after = get_all_post_type_supports( $post_type );
$this->assertEqualSets(
array(
'support_with_args' => array(
array(
'arg1',
'arg2',
),
),
'support_without_args' => true,
),
$post_type_supports
);
$this->assertEqualSets( array(), $post_type_supports_after );
}
public function test_does_not_add_query_var_if_not_public() { public function test_does_not_add_query_var_if_not_public() {
$this->set_permalink_structure( '/%postname%' ); $this->set_permalink_structure( '/%postname%' );