sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Twenty Seventeen: Improves code readability and code standards in files

Browse Source 
Adds better DocBlock comments and fixes some spacing issues based on PHP_CodeSniffer WordPress coding standards.

Props sstoqnov.

Fixes #39152.


git-svn-id: https://develop.svn.wordpress.org/trunk@39618 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
David A. Kennedy 2016-12-16 22:07:41 +00:00
parent 1f48d453d8
commit 665d60d680
16 changed files with 183 additions and 147 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/wp-content/themes/twentyseventeen/functions.php
View File

@ -310,6 +310,7 @@ add_action( 'widgets_init', 'twentyseventeen_widgets_init' );
*
* @since Twenty Seventeen 1.0
*
* @param string $link Link to single post/page.
* @return string 'Continue reading' link prepended with an ellipsis.
*/
function twentyseventeen_excerpt_more( $link ) {

1
src/wp-content/themes/twentyseventeen/inc/color-patterns.php
View File

@ -560,7 +560,6 @@ body.colors-custom,
}
}';
/**
* Filters Twenty Seventeen custom colors CSS.
*

2
src/wp-content/themes/twentyseventeen/inc/custom-header.php
View File

@ -111,6 +111,8 @@ endif; // End of twentyseventeen_header_style.
/**
* Customize video play/pause button in the custom header.
*
* @param array $settings Video settings.
*/
function twentyseventeen_video_controls( $settings ) {
$settings['l10n']['play'] = '<span class="screen-reader-text">' . __( 'Play background video', 'twentyseventeen' ) . '</span>' . twentyseventeen_get_svg( array( 'icon' => 'play' ) );

6
src/wp-content/themes/twentyseventeen/inc/customizer.php
View File

@ -123,6 +123,8 @@ add_action( 'customize_register', 'twentyseventeen_customize_register' );
/**
* Sanitize the page layout options.
*
* @param string $input Page layout.
*/
function twentyseventeen_sanitize_page_layout( $input ) {
$valid = array(
@ -139,11 +141,13 @@ function twentyseventeen_sanitize_page_layout( $input ) {
/**
* Sanitize the colorscheme.
*
* @param string $input Color scheme.
*/
function twentyseventeen_sanitize_colorscheme( $input ) {
$valid = array( 'light', 'dark', 'custom' );
if ( in_array( $input, $valid ) ) {
if ( in_array( $input, $valid, true ) ) {
return $input;
}

4
src/wp-content/themes/twentyseventeen/inc/template-tags.php
View File

@ -128,8 +128,8 @@ endif;
/**
* Display a front page section.
*
* @param $partial WP_Customize_Partial Partial associated with a selective refresh request.
* @param $id integer Front page section to display.
* @param WP_Customize_Partial $partial Partial associated with a selective refresh request.
* @param integer $id Front page section to display.
*/
function twentyseventeen_front_page_section( $partial = null, $id = 0 ) {
if ( is_a( $partial, 'WP_Customize_Partial' ) ) {

1
src/wp-content/themes/twentyseventeen/searchform.php
View File

@ -7,6 +7,7 @@
* @since 1.0
* @version 1.0
*/
?>
<?php $unique_id = esc_attr( uniqid( 'search-form-' ) ); ?>

7
src/wp-content/themes/twentyseventeen/template-parts/header/site-branding.php
View File

@ -21,8 +21,11 @@
<p class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a></p>
<?php endif; ?>
<?php $description = get_bloginfo( 'description', 'display' );
if ( $description || is_customize_preview() ) : ?>
<?php
$description = get_bloginfo( 'description', 'display' );
if ( $description || is_customize_preview() ) :
?>
<p class="site-description"><?php echo $description; ?></p>
<?php endif; ?>
</div><!-- .site-branding-text -->

9
src/wp-content/themes/twentyseventeen/template-parts/navigation/navigation-top.php
View File

@ -10,7 +10,14 @@
?>
<nav id="site-navigation" class="main-navigation" role="navigation" aria-label="<?php _e( 'Top Menu', 'twentyseventeen' ); ?>">
<button class="menu-toggle" aria-controls="top-menu" aria-expanded="false"><?php echo twentyseventeen_get_svg( array( 'icon' => 'bars' ) ); echo twentyseventeen_get_svg( array( 'icon' => 'close' ) ); _e( 'Menu', 'twentyseventeen' ); ?></button>
<button class="menu-toggle" aria-controls="top-menu" aria-expanded="false">
<?php
echo twentyseventeen_get_svg( array( 'icon' => 'bars' ) );
echo twentyseventeen_get_svg( array( 'icon' => 'close' ) );
_e( 'Menu', 'twentyseventeen' );
?>
</button>
<?php wp_nav_menu( array(
'theme_location' => 'top',
'menu_id' => 'top-menu',

36
src/wp-content/themes/twentyseventeen/template-parts/post/content-audio.php
View File

@ -14,22 +14,22 @@
<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
<?php
if ( is_sticky() && is_home() ) :
if ( is_sticky() && is_home() ) {
echo twentyseventeen_get_svg( array( 'icon' => 'thumb-tack' ) );
endif;
}
?>
<header class="entry-header">
<?php
if ( 'post' === get_post_type() ) :
if ( 'post' === get_post_type() ) {
echo '<div class="entry-meta">';
if ( is_single() ) :
if ( is_single() ) {
twentyseventeen_posted_on();
else :
} else {
echo twentyseventeen_time_link();
twentyseventeen_edit_link();
endif;
};
echo '</div><!-- .entry-meta -->';
endif;
};
if ( is_single() ) {
the_title( '<h1 class="entry-title">', '</h1>' );
@ -60,20 +60,21 @@
<div class="entry-content">
<?php if ( ! is_single() ) :
<?php
if ( ! is_single() ) {
// If not a single post, highlight the audio file.
if ( ! empty( $audio ) ) :
if ( ! empty( $audio ) ) {
foreach ( $audio as $audio_html ) {
echo '<div class="entry-audio">';
echo $audio_html;
echo '</div><!-- .entry-audio -->';
}
endif;
};
endif;
};
if ( is_single() || empty( $audio ) ) :
if ( is_single() || empty( $audio ) ) {
/* translators: %s: Name of current post */
the_content( sprintf(
@ -88,12 +89,15 @@
'link_after' => '</span>',
) );
endif; ?>
};
?>
</div><!-- .entry-content -->
<?php if ( is_single() ) : ?>
<?php twentyseventeen_entry_footer(); ?>
<?php endif; ?>
<?php
if ( is_single() ) {
twentyseventeen_entry_footer();
}
?>
</article><!-- #post-## -->

37
src/wp-content/themes/twentyseventeen/template-parts/post/content-gallery.php
View File

@ -9,26 +9,27 @@
* @since 1.0
* @version 1.0
*/
?>
<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
<?php
if ( is_sticky() && is_home() ) :
if ( is_sticky() && is_home() ) {
echo twentyseventeen_get_svg( array( 'icon' => 'thumb-tack' ) );
endif;
}
?>
<header class="entry-header">
<?php
if ( 'post' === get_post_type() ) :
if ( 'post' === get_post_type() ) {
echo '<div class="entry-meta">';
if ( is_single() ) :
if ( is_single() ) {
twentyseventeen_posted_on();
else :
} else {
echo twentyseventeen_time_link();
twentyseventeen_edit_link();
endif;
};
echo '</div><!-- .entry-meta -->';
endif;
};
if ( is_single() ) {
the_title( '<h1 class="entry-title">', '</h1>' );
@ -48,18 +49,19 @@
<div class="entry-content">
<?php if ( ! is_single() ) :
<?php
if ( ! is_single() ) {
// If not a single post, highlight the gallery.
if ( get_post_gallery() ) :
if ( get_post_gallery() ) {
echo '<div class="entry-gallery">';
echo get_post_gallery();
echo '</div>';
endif;
};
endif;
};
if ( is_single() || ! get_post_gallery() ) :
if ( is_single() || ! get_post_gallery() ) {
/* translators: %s: Name of current post */
the_content( sprintf(
@ -74,12 +76,15 @@
'link_after' => '</span>',
) );
endif; ?>
};
?>
</div><!-- .entry-content -->
<?php if ( is_single() ) : ?>
<?php twentyseventeen_entry_footer(); ?>
<?php endif; ?>
<?php
if ( is_single() ) {
twentyseventeen_entry_footer();
}
?>
</article><!-- #post-## -->

28
src/wp-content/themes/twentyseventeen/template-parts/post/content-image.php
View File

@ -9,26 +9,27 @@
* @since 1.0
* @version 1.0
*/
?>
<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
<?php
if ( is_sticky() && is_home() ) :
if ( is_sticky() && is_home() ) {
echo twentyseventeen_get_svg( array( 'icon' => 'thumb-tack' ) );
endif;
}
?>
<header class="entry-header">
<?php
if ( 'post' === get_post_type() ) :
if ( 'post' === get_post_type() ) {
echo '<div class="entry-meta">';
if ( is_single() ) :
if ( is_single() ) {
twentyseventeen_posted_on();
else :
} else {
echo twentyseventeen_time_link();
twentyseventeen_edit_link();
endif;
};
echo '</div><!-- .entry-meta -->';
endif;
};
if ( is_single() ) {
the_title( '<h1 class="entry-title">', '</h1>' );
@ -48,7 +49,7 @@
<div class="entry-content">
<?php if ( is_single() || '' === get_the_post_thumbnail() ) :
<?php if ( is_single() || '' === get_the_post_thumbnail() ) {
// Only show content if is a single post, or if there's no featured image.
/* translators: %s: Name of current post */
@ -64,12 +65,15 @@
'link_after' => '</span>',
) );
endif; ?>
};
?>
</div><!-- .entry-content -->
<?php if ( is_single() ) : ?>
<?php twentyseventeen_entry_footer(); ?>
<?php endif; ?>
<?php
if ( is_single() ) {
twentyseventeen_entry_footer();
}
?>
</article><!-- #post-## -->

38
src/wp-content/themes/twentyseventeen/template-parts/post/content-video.php
View File

@ -9,26 +9,27 @@
* @since 1.0
* @version 1.0
*/
?>
<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
<?php
if ( is_sticky() && is_home() ) :
if ( is_sticky() && is_home() ) {
echo twentyseventeen_get_svg( array( 'icon' => 'thumb-tack' ) );
endif;
}
?>
<header class="entry-header">
<?php
if ( 'post' === get_post_type() ) :
if ( 'post' === get_post_type() ) {
echo '<div class="entry-meta">';
if ( is_single() ) :
if ( is_single() ) {
twentyseventeen_posted_on();
else :
} else {
echo twentyseventeen_time_link();
twentyseventeen_edit_link();
endif;
}
echo '</div><!-- .entry-meta -->';
endif;
};
if ( is_single() ) {
the_title( '<h1 class="entry-title">', '</h1>' );
@ -58,20 +59,21 @@
<div class="entry-content">
<?php if ( ! is_single() ) :
<?php
if ( ! is_single() ) {
// If not a single post, highlight the video file.
if ( ! empty( $video ) ) :
if ( ! empty( $video ) ) {
foreach ( $video as $video_html ) {
echo '<div class="entry-video">';
echo $video_html;
echo '</div>';
}
endif;
};
endif;
};
if ( is_single() || empty( $video ) ) :
if ( is_single() || empty( $video ) ) {
/* translators: %s: Name of current post */
the_content( sprintf(
@ -85,13 +87,15 @@
'link_before' => '<span class="page-number">',
'link_after' => '</span>',
) );
endif; ?>
};
?>
</div><!-- .entry-content -->
<?php if ( is_single() ) : ?>
<?php twentyseventeen_entry_footer(); ?>
<?php endif; ?>
<?php
if ( is_single() ) {
twentyseventeen_entry_footer();
}
?>
</article><!-- #post-## -->

18
src/wp-content/themes/twentyseventeen/template-parts/post/content.php
View File

@ -20,16 +20,16 @@
?>
<header class="entry-header">
<?php
if ( 'post' === get_post_type() ) :
if ( 'post' === get_post_type() ) {
echo '<div class="entry-meta">';
if ( is_single() ) :
if ( is_single() ) {
twentyseventeen_posted_on();
else :
} else {
echo twentyseventeen_time_link();
twentyseventeen_edit_link();
endif;
};
echo '</div><!-- .entry-meta -->';
endif;
};
if ( is_single() ) {
the_title( '<h1 class="entry-title">', '</h1>' );
@ -64,8 +64,10 @@
?>
</div><!-- .entry-content -->
<?php if ( is_single() ) : ?>
<?php twentyseventeen_entry_footer(); ?>
<?php endif; ?>
<?php
if ( is_single() ) {
twentyseventeen_entry_footer();
}
?>
</article><!-- #post-## -->