sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove unnecessary checks for the existence of post meta data. Props filosofo. fixes #7018 

git-svn-id: https://develop.svn.wordpress.org/trunk@7985 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Ryan Boren 2008-05-22 16:33:06 +00:00
parent 681cc94a61
commit 66b9c9ea6d
1 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
wp-includes/post.php
View File

@ -44,14 +44,9 @@ function update_attached_file( $attachment_id, $file ) {
if ( !get_post( $attachment_id ) ) if ( !get_post( $attachment_id ) )
return false; return false;
$old_file = get_attached_file( $attachment_id, true );
$file = apply_filters( 'update_attached_file', $file, $attachment_id ); $file = apply_filters( 'update_attached_file', $file, $attachment_id );
if ( $old_file ) return update_post_meta( $attachment_id, '_wp_attached_file', $file );
return update_post_meta( $attachment_id, '_wp_attached_file', $file, $old_file );
else
return add_post_meta( $attachment_id, '_wp_attached_file', $file );
} }
/** /**
@ -1304,8 +1299,7 @@ function wp_insert_post($postarr = array(), $wp_error = false) {
else else
return 0; return 0;
} }
if ( ! update_post_meta($post_ID, '_wp_page_template', $page_template) ) update_post_meta($post_ID, '_wp_page_template', $page_template);
add_post_meta($post_ID, '_wp_page_template', $page_template, true);
} }
wp_transition_post_status($post_status, $previous_status, $post); wp_transition_post_status($post_status, $previous_status, $post);
@ -2242,14 +2236,9 @@ function wp_update_attachment_metadata( $post_id, $data ) {
if ( !$post =& get_post( $post_id ) ) if ( !$post =& get_post( $post_id ) )
return false; return false;
$old_data = wp_get_attachment_metadata( $post->ID, true );
$data = apply_filters( 'wp_update_attachment_metadata', $data, $post->ID ); $data = apply_filters( 'wp_update_attachment_metadata', $data, $post->ID );
if ( $old_data ) return update_post_meta( $post->ID, '_wp_attachment_metadata', $data);
return update_post_meta( $post->ID, '_wp_attachment_metadata', $data, $old_data );
else
return add_post_meta( $post->ID, '_wp_attachment_metadata', $data );
} }
/** /**