sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Comments: Rename WP_Comments_List_Table::comment_status_dropdown() to ::comment_type_dropdown().

Browse Source 
This better reflects the purpose of the method, which doesn't have anything to do with a comment status.

Follow-up to [48521].

Props davidbaumwald, johnbillion, SergeyBiryukov.
Fixes #51248.

git-svn-id: https://develop.svn.wordpress.org/trunk@48943 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2020-09-05 00:31:03 +00:00
parent 267e754b83
commit 677af117a9
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/wp-admin/includes/class-wp-comments-list-table.php
View File

@ -396,7 +396,7 @@ class WP_Comments_List_Table extends WP_List_Table {
if ( 'top' === $which ) { if ( 'top' === $which ) {
ob_start(); ob_start();
$this->comment_status_dropdown( $comment_type ); $this->comment_type_dropdown( $comment_type );
/** /**
* Fires just before the Filter submit button for comment types. * Fires just before the Filter submit button for comment types.
@ -475,10 +475,11 @@ class WP_Comments_List_Table extends WP_List_Table {
* Displays a comment type drop-down for filtering on the Comments list table. * Displays a comment type drop-down for filtering on the Comments list table.
* *
* @since 5.5.0 * @since 5.5.0
* @since 5.6.0 Renamed from `comment_status_dropdown()` to `comment_type_dropdown()`.
* *
* @param string $comment_type The current comment type slug. * @param string $comment_type The current comment type slug.
*/ */
protected function comment_status_dropdown( $comment_type ) { protected function comment_type_dropdown( $comment_type ) {
/** /**
* Filters the comment types shown in the drop-down menu on the Comments list table. * Filters the comment types shown in the drop-down menu on the Comments list table.
* *

2
tests/phpunit/tests/admin/includesListTable.php
View File

@ -319,7 +319,7 @@ class Tests_Admin_includesListTable extends WP_UnitTestCase {
/** /**
* @ticket 40188 * @ticket 40188
*/ */
public function test_filter_comment_status_dropdown_should_be_shown_if_there_are_comments() { public function test_filter_comment_type_dropdown_should_be_shown_if_there_are_comments() {
$post_id = self::factory()->post->create(); $post_id = self::factory()->post->create();
$comment_id = self::factory()->comment->create( $comment_id = self::factory()->comment->create(
array( array(