sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Multisite: Remove superfluous code from `network_edit_site_nav()` 

* Remove output buffering.
* Remove `esc_attr()` when outputting hard coded class names.
* Update documentation.

Fixes #15800.


git-svn-id: https://develop.svn.wordpress.org/trunk@37629 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jeremy Felt 2016-06-02 22:28:17 +00:00
parent 9bbc0df8d8
commit 6792df6fab
1 changed files with 17 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/wp-admin/includes/ms.php
View File

@ -1030,30 +1030,38 @@ jQuery(document).ready( function($) {
} }
/** /**
* Outputs the HTML for a network's "Edit Site" tabular interface * Outputs the HTML for a network's "Edit Site" tabular interface.
* *
* @since 4.6.0 * @since 4.6.0
* *
* @link https://core.trac.wordpress.org/ticket/15800 discussion
*
* @param $args { * @param $args {
* Optional. Array or string of Query parameters. * Optional. Array or string of Query parameters.
* *
* @type int $blog_id The site ID. Default is the current site. * @type int $blog_id The site ID. Default is the current site.
* @type array $links The tabs to include with (label|url|cap) keys * @type array $links The tabs to include with (label|url|cap) keys.
* @type string $selected The ID of the selected link * @type string $selected The ID of the selected link.
* } * }
*/ */
function network_edit_site_nav( $args = array() ) { function network_edit_site_nav( $args = array() ) {
/** /**
* Filters the links that appear on site-editing network pages * Filters the links that appear on site-editing network pages.
* *
* Default links: 'site-info', 'site-users', 'site-themes', and 'site-settings' * Default links: 'site-info', 'site-users', 'site-themes', and 'site-settings'.
* *
* @since 4.6.0 * @since 4.6.0
* *
* @param array Array of link data. * @param array $links {
* An array of link data representing individual network admin pages.
*
* @type array $link_slug {
* An array of information about the individual link to a page.
*
* $type string $label Label to use for the link.
* $type string $url URL, relative to `network_admin_url()` to use for the link.
* $type string $cap Capability required to see the link.
* }
* }
*/ */
$links = apply_filters( 'network_edit_site_nav_links', array( $links = apply_filters( 'network_edit_site_nav_links', array(
'site-info' => array( 'label' => __( 'Info' ), 'url' => 'site-info.php', 'cap' => 'manage_sites' ), 'site-info' => array( 'label' => __( 'Info' ), 'url' => 'site-info.php', 'cap' => 'manage_sites' ),
@ -1089,7 +1097,7 @@ function network_edit_site_nav( $args = array() ) {
} }
// Escape each class // Escape each class
$esc_classes = implode( ' ', array_map( 'esc_attr', $classes ) ); $esc_classes = implode( ' ', $classes );
// Get the URL for this link // Get the URL for this link
$url = add_query_arg( array( 'id' => $r['blog_id'] ), network_admin_url( $link['url'] ) ); $url = add_query_arg( array( 'id' => $r['blog_id'] ), network_admin_url( $link['url'] ) );
@ -1098,14 +1106,8 @@ function network_edit_site_nav( $args = array() ) {
$screen_links[ $link_id ] = '<a href="' . esc_url( $url ) . '" id="' . esc_attr( $link_id ) . '" class="' . $esc_classes . '">' . esc_html( $link['label'] ) . '</a>'; $screen_links[ $link_id ] = '<a href="' . esc_url( $url ) . '" id="' . esc_attr( $link_id ) . '" class="' . $esc_classes . '">' . esc_html( $link['label'] ) . '</a>';
} }
// Start a buffer
ob_start();
// All done! // All done!
echo '<h2 class="nav-tab-wrapper wp-clearfix">'; echo '<h2 class="nav-tab-wrapper wp-clearfix">';
echo implode( '', $screen_links ); echo implode( '', $screen_links );
echo '</h2>'; echo '</h2>';
// Output the nav
echo ob_get_clean();
} }