From 6905846fb4dd616102460a88d96acf9853b5bd57 Mon Sep 17 00:00:00 2001
From: Jonathan Desrosiers <desrosj@git.wordpress.org>
Date: Thu, 4 Jun 2020 15:46:00 +0000
Subject: [PATCH] Accessibility: Add the `aria-hidden` attribute to the
 auto-update related icons.

`<span>` elements used for displaying icons should use the `aria-hidden` attribute as they are purely decorative.

Props audrasjb, ryokuhi.
Fixes #50293.

git-svn-id: https://develop.svn.wordpress.org/trunk@47910 602fd350-edb4-49c9-b593-d223f7449a82
---
 src/wp-admin/includes/class-wp-ms-themes-list-table.php | 2 +-
 src/wp-admin/includes/class-wp-plugins-list-table.php   | 2 +-
 src/wp-admin/themes.php                                 | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/wp-admin/includes/class-wp-ms-themes-list-table.php b/src/wp-admin/includes/class-wp-ms-themes-list-table.php
index 11b17304c7..5b8c44ae92 100644
--- a/src/wp-admin/includes/class-wp-ms-themes-list-table.php
+++ b/src/wp-admin/includes/class-wp-ms-themes-list-table.php
@@ -748,7 +748,7 @@ class WP_MS_Themes_List_Table extends WP_List_Table {
 			$action
 		);
 
-		echo '<span class="dashicons dashicons-update spin hidden"></span>';
+		echo '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
 		echo '<span class="label">' . $text . '</span>';
 		echo '</a>';
 
diff --git a/src/wp-admin/includes/class-wp-plugins-list-table.php b/src/wp-admin/includes/class-wp-plugins-list-table.php
index 89f7dffc2b..d3233b451b 100644
--- a/src/wp-admin/includes/class-wp-plugins-list-table.php
+++ b/src/wp-admin/includes/class-wp-plugins-list-table.php
@@ -1066,7 +1066,7 @@ class WP_Plugins_List_Table extends WP_List_Table {
 						$action
 					);
 
-					echo '<span class="dashicons dashicons-update spin hidden"></span>';
+					echo '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
 					echo '<span class="label">' . $text . '</span>';
 					echo '</a>';
 
diff --git a/src/wp-admin/themes.php b/src/wp-admin/themes.php
index 5ea32017c3..e87f8edd6e 100644
--- a/src/wp-admin/themes.php
+++ b/src/wp-admin/themes.php
@@ -632,12 +632,12 @@ if ( ! is_multisite() && $broken_themes ) {
 				<p class="theme-autoupdate">
 				<# if ( data.autoupdate ) { #>
 					<a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="disable">
-						<span class="dashicons dashicons-update spin hidden"></span>
+						<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
 						<span class="label"><?php _e( 'Disable auto-updates' ); ?></span>
 					</a>
 				<# } else { #>
 					<a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="enable">
-						<span class="dashicons dashicons-update spin hidden"></span>
+						<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
 						<span class="label"><?php _e( 'Enable auto-updates' ); ?></span>
 					</a>
 				<# } #>