sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Accessibility: Add the aria-hidden attribute to the auto-update related icons.

Browse Source 
`<span>` elements used for displaying icons should use the `aria-hidden` attribute as they are purely decorative.

Props audrasjb, ryokuhi.
Fixes #50293.

git-svn-id: https://develop.svn.wordpress.org/trunk@47910 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jonathan Desrosiers 2020-06-04 15:46:00 +00:00
parent 5b2eaae4cf
commit 6905846fb4
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-admin/includes/class-wp-ms-themes-list-table.php
View File

@ -748,7 +748,7 @@ class WP_MS_Themes_List_Table extends WP_List_Table {
$action
);
echo '<span class="dashicons dashicons-update spin hidden"></span>';
echo '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
echo '<span class="label">' . $text . '</span>';
echo '</a>';

2
src/wp-admin/includes/class-wp-plugins-list-table.php
View File

@ -1066,7 +1066,7 @@ class WP_Plugins_List_Table extends WP_List_Table {
$action
);
echo '<span class="dashicons dashicons-update spin hidden"></span>';
echo '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
echo '<span class="label">' . $text . '</span>';
echo '</a>';

4
src/wp-admin/themes.php
View File

@ -632,12 +632,12 @@ if ( ! is_multisite() && $broken_themes ) {
<p class="theme-autoupdate">
<# if ( data.autoupdate ) { #>
<a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="disable">
<span class="dashicons dashicons-update spin hidden"></span>
<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
<span class="label"><?php _e( 'Disable auto-updates' ); ?></span>
</a>
<# } else { #>
<a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="enable">
<span class="dashicons dashicons-update spin hidden"></span>
<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
<span class="label"><?php _e( 'Enable auto-updates' ); ?></span>
</a>
<# } #>