From 6970857abf9d721c3b07f5e1de4e5ebdeb2e853a Mon Sep 17 00:00:00 2001 From: Andrew Nacin Date: Tue, 22 Feb 2011 04:24:20 +0000 Subject: [PATCH] Use get_comments_number() in comments_bubble() method. Removes chance of sprintf arguments error due to percent encoding in URLs and kills unnecessary translations. Escape translations into attributes. esc_url on admin_url. fixes #16611 for trunk. git-svn-id: https://develop.svn.wordpress.org/trunk@17475 602fd350-edb4-49c9-b593-d223f7449a82 --- wp-admin/includes/class-wp-list-table.php | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/wp-admin/includes/class-wp-list-table.php b/wp-admin/includes/class-wp-list-table.php index dc20adb0aa..086a163b6e 100644 --- a/wp-admin/includes/class-wp-list-table.php +++ b/wp-admin/includes/class-wp-list-table.php @@ -420,13 +420,9 @@ class WP_List_Table { if ( $pending_comments ) echo ''; - $link = "%s"; + $link = "%s"; - comments_number( - sprintf( $link, /* translators: comment count link */ _x( '0', 'comment count' ) ), - sprintf( $link, /* translators: comment count link */ _x( '1', 'comment count' ) ), - sprintf( $link, /* translators: comment count link: % will be substituted by comment count */ _x( '%', 'comment count' ) ) - ); + printf( $link, number_format_i18n( get_comments_number() ) ); if ( $pending_comments ) echo '';