sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Accessibility: Improve the way Internet Explorer 11 and JAWS announce fieldset legends.

Browse Source 
When Internet Explorer encounters a non interactive element with a `tabindex`
attribute, it adds the element to the accessibility tree with a `role=group` and
an accessible name computed from the element. This prevents JAWS from announcing
any fieldset legend within the element.

- removes `tabindex="0"` from the content and the toolbar containers: these tabindex attributes are no longer needed
- removes `aria-label="Main content"` from the content container: not needed
- keeps the media modal focus fallback introduced in [38142] by making the `#wpbody-content` element focusable only when needed

Props stevefaulkner, aardrian.
Fixes #43154.


git-svn-id: https://develop.svn.wordpress.org/trunk@44639 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Andrea Fercia 2019-01-17 11:54:23 +00:00
parent b71875d25e
commit 6b489bb125
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/js/media/views/modal.js
View File

@ -137,7 +137,9 @@ Modal = wp.media.View.extend(/** @lends wp.media.view.Modal.prototype */{
if ( null !== this.clickedOpenerEl ) { if ( null !== this.clickedOpenerEl ) {
this.clickedOpenerEl.focus(); this.clickedOpenerEl.focus();
} else { } else {
$( '#wpbody-content' ).focus(); $( '#wpbody-content' )
.attr( 'tabindex', '-1' )
.focus();
} }
this.propagate('close'); this.propagate('close');

2
src/wp-admin/admin-header.php
View File

@ -248,7 +248,7 @@ $current_screen->set_parentage( $parent_file );
?> ?>
<div id="wpbody-content" aria-label="<?php esc_attr_e( 'Main content' ); ?>" tabindex="0"> <div id="wpbody-content">
<?php <?php
$current_screen->render_screen_meta(); $current_screen->render_screen_meta();

2
src/wp-includes/class-wp-admin-bar.php
View File

@ -438,7 +438,7 @@ class WP_Admin_Bar {
<?php if ( ! is_admin() ) { ?> <?php if ( ! is_admin() ) { ?>
<a class="screen-reader-shortcut" href="#wp-toolbar" tabindex="1"><?php _e( 'Skip to toolbar' ); ?></a> <a class="screen-reader-shortcut" href="#wp-toolbar" tabindex="1"><?php _e( 'Skip to toolbar' ); ?></a>
<?php } ?> <?php } ?>
<div class="quicklinks" id="wp-toolbar" role="navigation" aria-label="<?php esc_attr_e( 'Toolbar' ); ?>" tabindex="0"> <div class="quicklinks" id="wp-toolbar" role="navigation" aria-label="<?php esc_attr_e( 'Toolbar' ); ?>">
<?php <?php
foreach ( $root->children as $group ) { foreach ( $root->children as $group ) {
$this->_render_group( $group ); $this->_render_group( $group );