From 6daffdf70b327fb769aca2c9843a4c831ec616ff Mon Sep 17 00:00:00 2001 From: Ryan Boren Date: Fri, 11 Nov 2005 00:55:31 +0000 Subject: [PATCH] Don't loop over empty list. Props skippy. fixes #1467 git-svn-id: https://develop.svn.wordpress.org/trunk@3038 602fd350-edb4-49c9-b593-d223f7449a82 --- wp-includes/pluggable-functions.php | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/wp-includes/pluggable-functions.php b/wp-includes/pluggable-functions.php index f741119277..9033392695 100644 --- a/wp-includes/pluggable-functions.php +++ b/wp-includes/pluggable-functions.php @@ -42,16 +42,18 @@ function get_userdata( $user_id ) { $metavalues = $wpdb->get_results("SELECT meta_key, meta_value FROM $wpdb->usermeta WHERE user_id = '$user_id'"); - foreach ( $metavalues as $meta ) { - @ $value = unserialize($meta->meta_value); - if ($value === FALSE) - $value = $meta->meta_value; - $user->{$meta->meta_key} = $value; + if ($metavalues) { + foreach ( $metavalues as $meta ) { + @ $value = unserialize($meta->meta_value); + if ($value === FALSE) + $value = $meta->meta_value; + $user->{$meta->meta_key} = $value; - // We need to set user_level from meta, not row - if ( $wpdb->prefix . 'user_level' == $meta->meta_key ) - $user->user_level = $meta->meta_value; - } + // We need to set user_level from meta, not row + if ( $wpdb->prefix . 'user_level' == $meta->meta_key ) + $user->user_level = $meta->meta_value; + } // end foreach + } //end if wp_cache_add($user_id, $user, 'users'); wp_cache_add($user->user_login, $user, 'users');