From 6e02c370bf8118b3ad886dfb2bdb28dacb108eb6 Mon Sep 17 00:00:00 2001 From: Felix Arntz Date: Wed, 7 Dec 2016 22:08:52 +0000 Subject: [PATCH] Multisite: Remove redundant `is_super_admin()` when checking for `edit_others_posts`. The super admin on multisite as well as the administrator on non-multisite both have this capability already. For custom post types using different capabilities this change ensures that only users with that capability have permissions. Fixes #39059. See #37616. git-svn-id: https://develop.svn.wordpress.org/trunk@39539 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/edit-form-advanced.php | 5 ++--- src/wp-admin/includes/class-wp-posts-list-table.php | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/wp-admin/edit-form-advanced.php b/src/wp-admin/edit-form-advanced.php index 803300f40d..852b88c792 100644 --- a/src/wp-admin/edit-form-advanced.php +++ b/src/wp-admin/edit-form-advanced.php @@ -308,9 +308,8 @@ if ( in_array( get_post_status( $post ), $stati ) ) { if ( ! ( 'pending' == get_post_status( $post ) && ! current_user_can( $post_type_object->cap->publish_posts ) ) ) add_meta_box('slugdiv', __('Slug'), 'post_slug_meta_box', null, 'normal', 'core'); -if ( post_type_supports($post_type, 'author') ) { - if ( is_super_admin() || current_user_can( $post_type_object->cap->edit_others_posts ) ) - add_meta_box('authordiv', __('Author'), 'post_author_meta_box', null, 'normal', 'core'); +if ( post_type_supports( $post_type, 'author' ) && current_user_can( $post_type_object->cap->edit_others_posts ) ) { + add_meta_box( 'authordiv', __( 'Author' ), 'post_author_meta_box', null, 'normal', 'core' ); } /** diff --git a/src/wp-admin/includes/class-wp-posts-list-table.php b/src/wp-admin/includes/class-wp-posts-list-table.php index ae0f2441fe..836eff7be4 100644 --- a/src/wp-admin/includes/class-wp-posts-list-table.php +++ b/src/wp-admin/includes/class-wp-posts-list-table.php @@ -1420,7 +1420,7 @@ class WP_Posts_List_Table extends WP_List_Table { if ( post_type_supports( $screen->post_type, 'author' ) ) : $authors_dropdown = ''; - if ( is_super_admin() || current_user_can( $post_type_object->cap->edit_others_posts ) ) : + if ( current_user_can( $post_type_object->cap->edit_others_posts ) ) : $users_opt = array( 'hide_if_only_one_author' => false, 'who' => 'authors',