From 6f22a931ffa976d6e6ec54315819c50f1eac799d Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Fri, 30 Aug 2019 18:57:51 +0000 Subject: [PATCH] Twenty Nineteen: Remove Baskerville Old Face from the font stack due to several shortcomings: * Being difficult to read due to its mix of thin and thick strokes. * Having poor language/extended character support. * Not having other weights/styles (bold, italic, etc) and relying on browser approximations of those variants. The next fonts down the stack (Garamond and Times) are more properly aligned to the appearance of the top-level serif font in the stack (Hoefler Text), and work better in its place. Props kjellr, Rarst, justintadlock. Fixes #45881. git-svn-id: https://develop.svn.wordpress.org/trunk@45919 602fd350-edb4-49c9-b593-d223f7449a82 --- .../sass/variables-site/_fonts.scss | 2 +- .../themes/twentynineteen/style-editor.css | 6 +++--- .../themes/twentynineteen/style-rtl.css | 18 +++++++++--------- src/wp-content/themes/twentynineteen/style.css | 18 +++++++++--------- 4 files changed, 22 insertions(+), 22 deletions(-) diff --git a/src/wp-content/themes/twentynineteen/sass/variables-site/_fonts.scss b/src/wp-content/themes/twentynineteen/sass/variables-site/_fonts.scss index 1003f4e3ca..59ab20b3c3 100644 --- a/src/wp-content/themes/twentynineteen/sass/variables-site/_fonts.scss +++ b/src/wp-content/themes/twentynineteen/sass/variables-site/_fonts.scss @@ -14,7 +14,7 @@ // Font and typographic variables -$font__body: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; +$font__body: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; $font__heading: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif; $font__fallbacks: ( /* Arabic */ diff --git a/src/wp-content/themes/twentynineteen/style-editor.css b/src/wp-content/themes/twentynineteen/style-editor.css index 415d9a4e91..557402f56b 100644 --- a/src/wp-content/themes/twentynineteen/style-editor.css +++ b/src/wp-content/themes/twentynineteen/style-editor.css @@ -611,7 +611,7 @@ body .wp-block[data-align="full"] { /** === Base Typography === */ body { font-size: 22px; - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; line-height: 1.8; color: #111; } @@ -792,7 +792,7 @@ figcaption, /** === Default Appender === */ .editor-default-block-appender .editor-default-block-appender__content { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-size: 22px; } @@ -1197,7 +1197,7 @@ ul.wp-block-archives li ul, } .wp-block-categories ul ul > li > a::before { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: normal; content: "– " counters(submenu, "– ", none); counter-increment: submenu; diff --git a/src/wp-content/themes/twentynineteen/style-rtl.css b/src/wp-content/themes/twentynineteen/style-rtl.css index 479a6d6bb3..fb6db2b98b 100644 --- a/src/wp-content/themes/twentynineteen/style-rtl.css +++ b/src/wp-content/themes/twentynineteen/style-rtl.css @@ -2212,7 +2212,7 @@ body { -webkit-font-smoothing: antialiased; -moz-osx-font-smoothing: grayscale; color: #111; - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: 400; font-size: 1em; line-height: 1.8; @@ -2226,7 +2226,7 @@ select, optgroup, textarea { color: #111; - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: 400; line-height: 1.8; text-rendering: optimizeLegibility; @@ -2286,7 +2286,7 @@ h6 { } .page-title { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; } .site-branding, @@ -3116,14 +3116,14 @@ body.page .main-navigation { } .main-navigation .main-menu .menu-item-has-children:not(.off-canvas)[focus-within] > .sub-menu .sub-menu > li > a::before { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: normal; content: "– " counters(submenu, "– ", none); counter-increment: submenu; } .main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus-within > .sub-menu .sub-menu > li > a::before { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: normal; content: "– " counters(submenu, "– ", none); counter-increment: submenu; @@ -3219,7 +3219,7 @@ body.page .main-navigation { .main-navigation .main-menu .menu-item-has-children:not(.off-canvas):hover > .sub-menu .sub-menu > li > a::before, .main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus > .sub-menu .sub-menu > li > a::before, .main-navigation .main-menu .menu-item-has-children.is-focused:not(.off-canvas) > .sub-menu .sub-menu > li > a::before { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: normal; content: "– " counters(submenu, "– ", none); counter-increment: submenu; @@ -5144,7 +5144,7 @@ body.page .main-navigation { .widget_recent_comments ul ul > li > a::before, .widget_recent_entries ul ul > li > a::before, .widget_rss ul ul > li > a::before { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: normal; content: "– " counters(submenu, "– ", none); counter-increment: submenu; @@ -5521,7 +5521,7 @@ body.page .main-navigation { } .entry .entry-content .wp-block-categories ul > li > a::before { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: normal; content: "– " counters(submenu, "– ", none); counter-increment: submenu; @@ -5577,7 +5577,7 @@ body.page .main-navigation { } .entry .entry-content .wp-block-verse { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-size: 22px; line-height: 1.8; } diff --git a/src/wp-content/themes/twentynineteen/style.css b/src/wp-content/themes/twentynineteen/style.css index e6d76f0e06..c48af2552d 100644 --- a/src/wp-content/themes/twentynineteen/style.css +++ b/src/wp-content/themes/twentynineteen/style.css @@ -2212,7 +2212,7 @@ body { -webkit-font-smoothing: antialiased; -moz-osx-font-smoothing: grayscale; color: #111; - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: 400; font-size: 1em; line-height: 1.8; @@ -2226,7 +2226,7 @@ select, optgroup, textarea { color: #111; - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: 400; line-height: 1.8; text-rendering: optimizeLegibility; @@ -2286,7 +2286,7 @@ h6 { } .page-title { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; } .site-branding, @@ -3116,14 +3116,14 @@ body.page .main-navigation { } .main-navigation .main-menu .menu-item-has-children:not(.off-canvas)[focus-within] > .sub-menu .sub-menu > li > a::before { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: normal; content: "– " counters(submenu, "– ", none); counter-increment: submenu; } .main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus-within > .sub-menu .sub-menu > li > a::before { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: normal; content: "– " counters(submenu, "– ", none); counter-increment: submenu; @@ -3219,7 +3219,7 @@ body.page .main-navigation { .main-navigation .main-menu .menu-item-has-children:not(.off-canvas):hover > .sub-menu .sub-menu > li > a::before, .main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus > .sub-menu .sub-menu > li > a::before, .main-navigation .main-menu .menu-item-has-children.is-focused:not(.off-canvas) > .sub-menu .sub-menu > li > a::before { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: normal; content: "– " counters(submenu, "– ", none); counter-increment: submenu; @@ -5150,7 +5150,7 @@ body.page .main-navigation { .widget_recent_comments ul ul > li > a::before, .widget_recent_entries ul ul > li > a::before, .widget_rss ul ul > li > a::before { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: normal; content: "– " counters(submenu, "– ", none); counter-increment: submenu; @@ -5533,7 +5533,7 @@ body.page .main-navigation { } .entry .entry-content .wp-block-categories ul > li > a::before { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-weight: normal; content: "– " counters(submenu, "– ", none); counter-increment: submenu; @@ -5589,7 +5589,7 @@ body.page .main-navigation { } .entry .entry-content .wp-block-verse { - font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; + font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif; font-size: 22px; line-height: 1.8; }