sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Twenty Nineteen: Remove Baskerville Old Face from the font stack due to several shortcomings:

Browse Source 
* Being difficult to read due to its mix of thin and thick strokes.
* Having poor language/extended character support.
* Not having other weights/styles (bold, italic, etc) and relying on browser approximations of those variants.

The next fonts down the stack (Garamond and Times) are more properly aligned to the appearance of the top-level serif font in the stack (Hoefler Text), and work better in its place.

Props kjellr, Rarst, justintadlock.
Fixes #45881.

git-svn-id: https://develop.svn.wordpress.org/trunk@45919 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2019-08-30 18:57:51 +00:00
parent 5377bc484b
commit 6f22a931ff
4 changed files with 22 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-content/themes/twentynineteen/sass/variables-site/_fonts.scss
View File

@ -14,7 +14,7 @@
// Font and typographic variables // Font and typographic variables
$font__body: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; $font__body: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
$font__heading: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif; $font__heading: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
$font__fallbacks: ( $font__fallbacks: (
/* Arabic */ /* Arabic */

6
src/wp-content/themes/twentynineteen/style-editor.css
View File

@ -611,7 +611,7 @@ body .wp-block[data-align="full"] {
/** === Base Typography === */ /** === Base Typography === */
body { body {
font-size: 22px; font-size: 22px;
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
line-height: 1.8; line-height: 1.8;
color: #111; color: #111;
} }
@ -792,7 +792,7 @@ figcaption,
/** === Default Appender === */ /** === Default Appender === */
.editor-default-block-appender .editor-default-block-appender__content { .editor-default-block-appender .editor-default-block-appender__content {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-size: 22px; font-size: 22px;
} }
@ -1197,7 +1197,7 @@ ul.wp-block-archives li ul,
} }
.wp-block-categories ul ul > li > a::before { .wp-block-categories ul ul > li > a::before {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: normal; font-weight: normal;
content: "– " counters(submenu, "– ", none); content: "– " counters(submenu, "– ", none);
counter-increment: submenu; counter-increment: submenu;

18
src/wp-content/themes/twentynineteen/style-rtl.css
View File

@ -2212,7 +2212,7 @@ body {
-webkit-font-smoothing: antialiased; -webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale; -moz-osx-font-smoothing: grayscale;
color: #111; color: #111;
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: 400; font-weight: 400;
font-size: 1em; font-size: 1em;
line-height: 1.8; line-height: 1.8;
@ -2226,7 +2226,7 @@ select,
optgroup, optgroup,
textarea { textarea {
color: #111; color: #111;
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: 400; font-weight: 400;
line-height: 1.8; line-height: 1.8;
text-rendering: optimizeLegibility; text-rendering: optimizeLegibility;
@ -2286,7 +2286,7 @@ h6 {
} }
.page-title { .page-title {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
} }
.site-branding, .site-branding,
@ -3116,14 +3116,14 @@ body.page .main-navigation {
} }
.main-navigation .main-menu .menu-item-has-children:not(.off-canvas)[focus-within] > .sub-menu .sub-menu > li > a::before { .main-navigation .main-menu .menu-item-has-children:not(.off-canvas)[focus-within] > .sub-menu .sub-menu > li > a::before {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: normal; font-weight: normal;
content: "– " counters(submenu, "– ", none); content: "– " counters(submenu, "– ", none);
counter-increment: submenu; counter-increment: submenu;
} }
.main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus-within > .sub-menu .sub-menu > li > a::before { .main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus-within > .sub-menu .sub-menu > li > a::before {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: normal; font-weight: normal;
content: "– " counters(submenu, "– ", none); content: "– " counters(submenu, "– ", none);
counter-increment: submenu; counter-increment: submenu;
@ -3219,7 +3219,7 @@ body.page .main-navigation {
.main-navigation .main-menu .menu-item-has-children:not(.off-canvas):hover > .sub-menu .sub-menu > li > a::before, .main-navigation .main-menu .menu-item-has-children:not(.off-canvas):hover > .sub-menu .sub-menu > li > a::before,
.main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus > .sub-menu .sub-menu > li > a::before, .main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus > .sub-menu .sub-menu > li > a::before,
.main-navigation .main-menu .menu-item-has-children.is-focused:not(.off-canvas) > .sub-menu .sub-menu > li > a::before { .main-navigation .main-menu .menu-item-has-children.is-focused:not(.off-canvas) > .sub-menu .sub-menu > li > a::before {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: normal; font-weight: normal;
content: "– " counters(submenu, "– ", none); content: "– " counters(submenu, "– ", none);
counter-increment: submenu; counter-increment: submenu;
@ -5144,7 +5144,7 @@ body.page .main-navigation {
.widget_recent_comments ul ul > li > a::before, .widget_recent_comments ul ul > li > a::before,
.widget_recent_entries ul ul > li > a::before, .widget_recent_entries ul ul > li > a::before,
.widget_rss ul ul > li > a::before { .widget_rss ul ul > li > a::before {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: normal; font-weight: normal;
content: "– " counters(submenu, "– ", none); content: "– " counters(submenu, "– ", none);
counter-increment: submenu; counter-increment: submenu;
@ -5521,7 +5521,7 @@ body.page .main-navigation {
} }
.entry .entry-content .wp-block-categories ul > li > a::before { .entry .entry-content .wp-block-categories ul > li > a::before {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: normal; font-weight: normal;
content: "– " counters(submenu, "– ", none); content: "– " counters(submenu, "– ", none);
counter-increment: submenu; counter-increment: submenu;
@ -5577,7 +5577,7 @@ body.page .main-navigation {
} }
.entry .entry-content .wp-block-verse { .entry .entry-content .wp-block-verse {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-size: 22px; font-size: 22px;
line-height: 1.8; line-height: 1.8;
} }

18
src/wp-content/themes/twentynineteen/style.css
View File

@ -2212,7 +2212,7 @@ body {
-webkit-font-smoothing: antialiased; -webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale; -moz-osx-font-smoothing: grayscale;
color: #111; color: #111;
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: 400; font-weight: 400;
font-size: 1em; font-size: 1em;
line-height: 1.8; line-height: 1.8;
@ -2226,7 +2226,7 @@ select,
optgroup, optgroup,
textarea { textarea {
color: #111; color: #111;
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: 400; font-weight: 400;
line-height: 1.8; line-height: 1.8;
text-rendering: optimizeLegibility; text-rendering: optimizeLegibility;
@ -2286,7 +2286,7 @@ h6 {
} }
.page-title { .page-title {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
} }
.site-branding, .site-branding,
@ -3116,14 +3116,14 @@ body.page .main-navigation {
} }
.main-navigation .main-menu .menu-item-has-children:not(.off-canvas)[focus-within] > .sub-menu .sub-menu > li > a::before { .main-navigation .main-menu .menu-item-has-children:not(.off-canvas)[focus-within] > .sub-menu .sub-menu > li > a::before {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: normal; font-weight: normal;
content: "– " counters(submenu, "– ", none); content: "– " counters(submenu, "– ", none);
counter-increment: submenu; counter-increment: submenu;
} }
.main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus-within > .sub-menu .sub-menu > li > a::before { .main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus-within > .sub-menu .sub-menu > li > a::before {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: normal; font-weight: normal;
content: "– " counters(submenu, "– ", none); content: "– " counters(submenu, "– ", none);
counter-increment: submenu; counter-increment: submenu;
@ -3219,7 +3219,7 @@ body.page .main-navigation {
.main-navigation .main-menu .menu-item-has-children:not(.off-canvas):hover > .sub-menu .sub-menu > li > a::before, .main-navigation .main-menu .menu-item-has-children:not(.off-canvas):hover > .sub-menu .sub-menu > li > a::before,
.main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus > .sub-menu .sub-menu > li > a::before, .main-navigation .main-menu .menu-item-has-children:not(.off-canvas):focus > .sub-menu .sub-menu > li > a::before,
.main-navigation .main-menu .menu-item-has-children.is-focused:not(.off-canvas) > .sub-menu .sub-menu > li > a::before { .main-navigation .main-menu .menu-item-has-children.is-focused:not(.off-canvas) > .sub-menu .sub-menu > li > a::before {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: normal; font-weight: normal;
content: "– " counters(submenu, "– ", none); content: "– " counters(submenu, "– ", none);
counter-increment: submenu; counter-increment: submenu;
@ -5150,7 +5150,7 @@ body.page .main-navigation {
.widget_recent_comments ul ul > li > a::before, .widget_recent_comments ul ul > li > a::before,
.widget_recent_entries ul ul > li > a::before, .widget_recent_entries ul ul > li > a::before,
.widget_rss ul ul > li > a::before { .widget_rss ul ul > li > a::before {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: normal; font-weight: normal;
content: "– " counters(submenu, "– ", none); content: "– " counters(submenu, "– ", none);
counter-increment: submenu; counter-increment: submenu;
@ -5533,7 +5533,7 @@ body.page .main-navigation {
} }
.entry .entry-content .wp-block-categories ul > li > a::before { .entry .entry-content .wp-block-categories ul > li > a::before {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-weight: normal; font-weight: normal;
content: "– " counters(submenu, "– ", none); content: "– " counters(submenu, "– ", none);
counter-increment: submenu; counter-increment: submenu;
@ -5589,7 +5589,7 @@ body.page .main-navigation {
} }
.entry .entry-content .wp-block-verse { .entry .entry-content .wp-block-verse {
font-family: "NonBreakingSpaceOverride", "Hoefler Text", "Baskerville Old Face", Garamond, "Times New Roman", serif; font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
font-size: 22px; font-size: 22px;
line-height: 1.8; line-height: 1.8;
} }