sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

REST API: Fix test failures.

Browse Source 
- Fix leak in setup_notify_comment() test help by removing the comment_flood_filter.
- Correct uses of $term_taxonomy_id -> $term_id in Category and Tags routing.
- Temporarily remove the metadata tests for canola.jpg as that file does not have an exifdata.  Will need to update the test.

Props jorbin, rmccue, nacin
See #38373.

git-svn-id: https://develop.svn.wordpress.org/trunk@38834 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Rachel Baker 2016-10-20 05:12:26 +00:00
parent 008f16164e
commit 72418d4bc1
4 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/phpunit/tests/comment.php
View File

@ -460,7 +460,7 @@ class Tests_Comment extends WP_UnitTestCase {
$this->assertFalse( $notification_sent, 'Moderator notification setting on, filter set to off' );
remove_filter( 'notify_moderator', '__return_false' );
remove_filter( 'comment_flood_filter', '__return_false' );
}
/**
@ -481,6 +481,7 @@ class Tests_Comment extends WP_UnitTestCase {
$this->assertTrue( $notification_sent, 'Moderator notification setting off, filter set to on' );
remove_filter( 'notify_moderator', '__return_true' );
remove_filter( 'comment_flood_filter', '__return_false' );
}
/**
@ -502,6 +503,7 @@ class Tests_Comment extends WP_UnitTestCase {
$this->assertFalse( $notification_sent, 'Test with author notification setting on, filter set to off' );
remove_filter( 'notify_post_author', '__return_false' );
remove_filter( 'comment_flood_filter', '__return_false' );
}
/**
@ -522,6 +524,7 @@ class Tests_Comment extends WP_UnitTestCase {
$this->assertTrue( $notification_sent, 'Test with author notification setting off, filter set to on' );
remove_filter( 'notify_post_author', '__return_true' );
remove_filter( 'comment_flood_filter', '__return_false' );
}
/**

2
tests/phpunit/tests/rest-api/rest-attachments-controller.php
View File

@ -425,8 +425,6 @@ class WP_Test_REST_Attachments_Controller extends WP_Test_REST_Post_Type_Control
$data = $response->get_data();
$this->assertEquals( 201, $response->get_status() );
$this->assertEquals( 'image', $data['media_type'] );
$this->assertEquals( 'A field of amazing canola', $data['title']['rendered'] );
$this->assertEquals( 'The description for the image', $data['caption'] );
}
public function test_create_item_default_filename_title() {

2
tests/phpunit/tests/rest-api/rest-categories-controller.php
View File

@ -677,7 +677,7 @@ class WP_Test_REST_Categories_Controller extends WP_Test_REST_Controller_Testcas
$parent = get_term_by( 'id', $this->factory->category->create(), 'category' );
$term = get_term_by( 'id', $this->factory->category->create(), 'category' );
$request = new WP_REST_Request( 'POST', '/wp/v2/categories/' . $term->term_taxonomy_id );
$request = new WP_REST_Request( 'POST', '/wp/v2/categories/' . $term->term_id );
$request->set_param( 'parent', $parent->term_id );
$response = $this->server->dispatch( $request );
$this->assertEquals( 200, $response->get_status() );

2
tests/phpunit/tests/rest-api/rest-tags-controller.php
View File

@ -531,7 +531,7 @@ class WP_Test_REST_Tags_Controller extends WP_Test_REST_Controller_Testcase {
wp_set_current_user( $this->administrator );
$term = get_term_by( 'id', $this->factory->tag->create(), 'post_tag' );
$request = new WP_REST_Request( 'POST', '/wp/v2/tags/' . $term->term_taxonomy_id );
$request = new WP_REST_Request( 'POST', '/wp/v2/tags/' . $term->term_id );
$request->set_param( 'parent', REST_TESTS_IMPOSSIBLY_HIGH_NUMBER );
$response = $this->server->dispatch( $request );
$this->assertErrorResponse( 'rest_taxonomy_not_hierarchical', $response, 400 );