From 73671e85c5b0d4ea87ebec3ae561f0074c669884 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Sun, 16 Aug 2020 17:46:51 +0000 Subject: [PATCH] Site Health: Only display the warning about the `post_max_size` PHP value when it's lower than `upload_max_filesize`. Previously, the warning was displayed even if the value was higher than `upload_max_filesize`, which made the report inaccurate, as these values don't necessarily have to match. Props oakesjosh, jeroenrotty, desrosj, Clorith. Fixes #50945. git-svn-id: https://develop.svn.wordpress.org/trunk@48800 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/class-wp-site-health.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/wp-admin/includes/class-wp-site-health.php b/src/wp-admin/includes/class-wp-site-health.php index 2fd570318d..94bc35b834 100644 --- a/src/wp-admin/includes/class-wp-site-health.php +++ b/src/wp-admin/includes/class-wp-site-health.php @@ -2049,10 +2049,10 @@ class WP_Site_Health { $post_max_size = ini_get( 'post_max_size' ); $upload_max_size = ini_get( 'upload_max_filesize' ); - if ( wp_convert_hr_to_bytes( $post_max_size ) !== wp_convert_hr_to_bytes( $upload_max_size ) ) { + if ( wp_convert_hr_to_bytes( $post_max_size ) < wp_convert_hr_to_bytes( $upload_max_size ) ) { $result['label'] = sprintf( /* translators: 1: post_max_size, 2: upload_max_filesize */ - __( 'Mismatched "%1$s" and "%2$s" values.' ), + __( 'The "%1$s" value is smaller than "%2$s".' ), 'post_max_size', 'upload_max_filesize' ); @@ -2061,7 +2061,7 @@ class WP_Site_Health { '

%s

', sprintf( /* translators: 1: post_max_size, 2: upload_max_filesize */ - __( 'The settings for %1$s and %2$s are not the same, this could cause some problems when trying to upload files.' ), + __( 'The setting for %1$s is smaller than %2$s, this could cause some problems when trying to upload files.' ), 'post_max_size', 'upload_max_filesize' )