sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Site Health: Only display the warning about the post_max_size PHP value when it's lower than upload_max_filesize.

Browse Source 
Previously, the warning was displayed even if the value was higher than `upload_max_filesize`, which made the report inaccurate, as these values don't necessarily have to match.

Props oakesjosh, jeroenrotty, desrosj, Clorith.
Fixes #50945.

git-svn-id: https://develop.svn.wordpress.org/trunk@48800 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2020-08-16 17:46:51 +00:00
parent a1e05cff28
commit 73671e85c5
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/wp-admin/includes/class-wp-site-health.php
View File

@ -2049,10 +2049,10 @@ class WP_Site_Health {
$post_max_size = ini_get( 'post_max_size' ); $post_max_size = ini_get( 'post_max_size' );
$upload_max_size = ini_get( 'upload_max_filesize' ); $upload_max_size = ini_get( 'upload_max_filesize' );
if ( wp_convert_hr_to_bytes( $post_max_size ) !== wp_convert_hr_to_bytes( $upload_max_size ) ) { if ( wp_convert_hr_to_bytes( $post_max_size ) < wp_convert_hr_to_bytes( $upload_max_size ) ) {
$result['label'] = sprintf( $result['label'] = sprintf(
/* translators: 1: post_max_size, 2: upload_max_filesize */ /* translators: 1: post_max_size, 2: upload_max_filesize */
__( 'Mismatched "%1$s" and "%2$s" values.' ), __( 'The "%1$s" value is smaller than "%2$s".' ),
'post_max_size', 'post_max_size',
'upload_max_filesize' 'upload_max_filesize'
); );
@ -2061,7 +2061,7 @@ class WP_Site_Health {
'<p>%s</p>', '<p>%s</p>',
sprintf( sprintf(
/* translators: 1: post_max_size, 2: upload_max_filesize */ /* translators: 1: post_max_size, 2: upload_max_filesize */
__( 'The settings for %1$s and %2$s are not the same, this could cause some problems when trying to upload files.' ), __( 'The setting for %1$s is smaller than %2$s, this could cause some problems when trying to upload files.' ),
'<code>post_max_size</code>', '<code>post_max_size</code>',
'<code>upload_max_filesize</code>' '<code>upload_max_filesize</code>'
) )