sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Transient timeouts are untestable when `WP_INSTALLING` is defined and set to ANY value. Transient timeouts cannot be tested during multisite runs because `wpmu_create_blog()` sets `WP_INSTALLING`. I have zero idea how these tests ever passed. 

See #28706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28965 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor 2014-07-03 01:16:33 +00:00
parent 80a817ebcc
commit 73bde8a278
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/phpunit/includes/install.php
View File

@ -9,7 +9,6 @@ error_reporting( E_ALL & ~E_DEPRECATED & ~E_STRICT );
$config_file_path = $argv[1];
$multisite = ! empty( $argv[2] );
define( 'WP_INSTALLING', true );
require_once $config_file_path;
require_once dirname( __FILE__ ) . '/functions.php';

8
tests/phpunit/tests/option/transient.php
View File

@ -38,6 +38,10 @@ class Tests_Option_Transient extends WP_UnitTestCase {
* @ticket 22807
*/
function test_transient_data_with_timeout() {
if ( is_multisite() ) {
$this->markTestSkipped( 'Not testable in MS: wpmu_create_blog() defines WP_INSTALLING.' );
}
$key = rand_str();
$value = rand_str();
@ -59,6 +63,10 @@ class Tests_Option_Transient extends WP_UnitTestCase {
* @ticket 22807
*/
function test_transient_add_timeout() {
if ( is_multisite() ) {
$this->markTestSkipped( 'Not testable in MS: wpmu_create_blog() defines WP_INSTALLING.' );
}
$key = rand_str();
$value = rand_str();
$value2 = rand_str();