From 75ac2cf13187399b29d71b02375f556c4d5547fd Mon Sep 17 00:00:00 2001 From: Andrew Ozz Date: Tue, 3 Dec 2013 00:44:22 +0000 Subject: [PATCH] Heartbeat: - Bring back heartbeat.interval(). - Rename wp_disable_heartbeat_suspend() to wp_heartbeat_set_suspension(). - Rename the option for disabling suspension from options.suspend to options.suspension. Fixes #25073. git-svn-id: https://develop.svn.wordpress.org/trunk@26549 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/misc.php | 6 +++--- src/wp-admin/js/inline-edit-post.js | 2 +- src/wp-admin/js/post.js | 2 +- src/wp-includes/js/heartbeat.js | 8 ++++---- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/wp-admin/includes/misc.php b/src/wp-admin/includes/misc.php index fc7abcf534..641e2d4488 100644 --- a/src/wp-admin/includes/misc.php +++ b/src/wp-admin/includes/misc.php @@ -743,13 +743,13 @@ add_filter( 'heartbeat_received', 'wp_refresh_post_nonces', 10, 3 ); * * @since 3.8 */ -function wp_disable_heartbeat_suspend( $settings ) { +function wp_heartbeat_set_suspension( $settings ) { global $pagenow; if ( 'post.php' === $pagenow || 'post-new.php' === $pagenow ) { - $settings['suspend'] = 'disable'; + $settings['suspension'] = 'disable'; } return $settings; } -add_filter( 'heartbeat_settings', 'wp_disable_heartbeat_suspend' ); +add_filter( 'heartbeat_settings', 'wp_heartbeat_set_suspension' ); diff --git a/src/wp-admin/js/inline-edit-post.js b/src/wp-admin/js/inline-edit-post.js index bca069f347..81f302f3b3 100644 --- a/src/wp-admin/js/inline-edit-post.js +++ b/src/wp-admin/js/inline-edit-post.js @@ -352,7 +352,7 @@ $( document ).on( 'heartbeat-tick.wp-check-locked-posts', function( e, data ) { }).ready( function() { // Set the heartbeat interval to 15 sec. if ( typeof wp !== 'undefined' && wp.heartbeat ) { - wp.heartbeat.setInterval( 15 ); + wp.heartbeat.interval( 15 ); } }); diff --git a/src/wp-admin/js/post.js b/src/wp-admin/js/post.js index 814e93cf95..51538521a9 100644 --- a/src/wp-admin/js/post.js +++ b/src/wp-admin/js/post.js @@ -377,7 +377,7 @@ jQuery(document).ready( function($) { // Set the heartbeat interval to 15 sec. if post lock dialogs are enabled if ( typeof wp !== 'undefined' && wp.heartbeat && $('#post-lock-dialog').length ) { - wp.heartbeat.setInterval( 15 ); + wp.heartbeat.interval( 15 ); } // multi-taxonomies diff --git a/src/wp-includes/js/heartbeat.js b/src/wp-includes/js/heartbeat.js index bc0faa4b5a..ab4eaced59 100644 --- a/src/wp-includes/js/heartbeat.js +++ b/src/wp-includes/js/heartbeat.js @@ -132,7 +132,7 @@ settings.screenId = options.screenId || 'front'; } - if ( options.suspend === 'disable' ) { + if ( options.suspension === 'disable' ) { settings.suspendEnabled = false; } } @@ -342,7 +342,7 @@ // Do this last, can trigger the next XHR if connection time > 5 sec. and newInterval == 'fast' if ( newInterval ) { - setInterval( newInterval ); + interval( newInterval ); } }).fail( function( jqXHR, textStatus, error ) { setErrorState( textStatus || 'unknown', jqXHR.status ); @@ -605,7 +605,7 @@ * @param string ticks Used with speed = 'fast' or 5, how many ticks before the interval reverts back * @return int Current interval in seconds */ - function setInterval( speed, ticks ) { + function interval( speed, ticks ) { var interval, oldInerval = settings.tempInterval ? settings.tempInterval : settings.mainInterval; if ( speed ) { @@ -725,7 +725,7 @@ hasFocus: hasFocus, connectNow: connectNow, disableSuspend: disableSuspend, - setInterval: setInterval, + interval: interval, hasConnectionError: hasConnectionError, enqueue: enqueue, dequeue: dequeue,