sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Users: In wp_list_authors(), check for author's post count before getting author's metadata.

Browse Source 
This significantly reduces the number of SQL queries when `wp_list_authors()` is called on a site where the majority of users don't have any posts, e.g. a membership site.

Props billerickson, ianbelanger, dswebsme.
Fixes #45105.

git-svn-id: https://develop.svn.wordpress.org/trunk@45235 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2019-04-17 14:49:49 +00:00
parent 60fd53ef96
commit 774dceac30
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/wp-includes/author-template.php
View File

@ -442,15 +442,15 @@ function wp_list_authors( $args = '' ) {
$author_count[ $row->post_author ] = $row->count; $author_count[ $row->post_author ] = $row->count;
} }
foreach ( $authors as $author_id ) { foreach ( $authors as $author_id ) {
$author = get_userdata( $author_id ); $posts = isset( $author_count[ $author_id ] ) ? $author_count[ $author_id ] : 0;
if ( $args['exclude_admin'] && 'admin' == $author->display_name ) { if ( ! $posts && $args['hide_empty'] ) {
continue; continue;
} }
$posts = isset( $author_count[ $author->ID ] ) ? $author_count[ $author->ID ] : 0; $author = get_userdata( $author_id );
if ( ! $posts && $args['hide_empty'] ) { if ( $args['exclude_admin'] && 'admin' === $author->display_name ) {
continue; continue;
} }