sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use microtime() instead of incrementors for last_changed to to avoid race conditions with cache evictions. 

Props westi
fixes #23448


git-svn-id: https://develop.svn.wordpress.org/trunk@23401 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Ryan Boren 2013-02-11 18:08:14 +00:00
parent 679339ffaa
commit 77e5536195
4 changed files with 8 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
wp-includes/comment.php
View File

@ -251,7 +251,7 @@ class WP_Comment_Query {
$key = md5( serialize( compact(array_keys($defaults)) ) );
$last_changed = wp_cache_get( 'last_changed', 'comment' );
if ( ! $last_changed ) {
$last_changed = 1;
$last_changed = microtime();
wp_cache_set( 'last_changed', $last_changed, 'comment' );
}
$cache_key = "get_comments:$key:$last_changed";
@ -1292,12 +1292,7 @@ function wp_insert_comment($commentdata) {
$comment = get_comment($id);
do_action('wp_insert_comment', $id, $comment);
if ( function_exists( 'wp_cache_incr' ) ) {
wp_cache_incr( 'last_changed', 1, 'comment' );
} else {
$last_changed = wp_cache_get( 'last_changed', 'comment' );
wp_cache_set( 'last_changed', $last_changed + 1, 'comment' );
}
wp_cache_set( 'last_changed', microtime(), 'comment' );
return $id;
}
@ -2050,12 +2045,7 @@ function clean_comment_cache($ids) {
foreach ( (array) $ids as $id )
wp_cache_delete($id, 'comment');
if ( function_exists( 'wp_cache_incr' ) ) {
wp_cache_incr( 'last_changed', 1, 'comment' );
} else {
$last_changed = wp_cache_get( 'last_changed', 'comment' );
wp_cache_set( 'last_changed', $last_changed + 1, 'comment' );
}
wp_cache_set( 'last_changed', microtime(), 'comment' );
}
/**

2
wp-includes/general-template.php
View File

@ -919,7 +919,7 @@ function wp_get_archives($args = '') {
$last_changed = wp_cache_get( 'last_changed', 'posts' );
if ( ! $last_changed ) {
$last_changed = 1;
$last_changed = microtime();
wp_cache_set( 'last_changed', $last_changed, 'posts' );
}

9
wp-includes/post.php
View File

@ -3653,7 +3653,7 @@ function get_pages($args = '') {
$key = md5( serialize( compact(array_keys($defaults)) ) );
$last_changed = wp_cache_get( 'last_changed', 'posts' );
if ( ! $last_changed ) {
$last_changed = 1;
$last_changed = microtime();
wp_cache_set( 'last_changed', $last_changed, 'posts' );
}
@ -4672,12 +4672,7 @@ function clean_post_cache( $post ) {
do_action( 'clean_page_cache', $post->ID );
}
if ( function_exists( 'wp_cache_incr' ) ) {
wp_cache_incr( 'last_changed', 1, 'posts' );
} else {
$last_changed = wp_cache_get( 'last_changed', 'posts' );
wp_cache_set( 'last_changed', $last_changed + 1, 'posts' );
}
wp_cache_set( 'last_changed', microtime(), 'posts' );
}
/**

9
wp-includes/taxonomy.php
View File

@ -1242,7 +1242,7 @@ function get_terms($taxonomies, $args = '') {
$key = md5( serialize( compact(array_keys($defaults)) ) . serialize( $taxonomies ) . $filter_key );
$last_changed = wp_cache_get( 'last_changed', 'terms' );
if ( ! $last_changed ) {
$last_changed = 1;
$last_changed = microtime();
wp_cache_set( 'last_changed', $last_changed, 'terms' );
}
$cache_key = "get_terms:$key:$last_changed";
@ -2711,12 +2711,7 @@ function clean_term_cache($ids, $taxonomy = '', $clean_taxonomy = true) {
do_action('clean_term_cache', $ids, $taxonomy);
}
if ( function_exists( 'wp_cache_incr' ) ) {
wp_cache_incr( 'last_changed', 1, 'terms' );
} else {
$last_changed = wp_cache_get( 'last_changed', 'terms' );
wp_cache_set( 'last_changed', $last_changed + 1, 'terms' );
}
wp_cache_set( 'last_changed', microtime(), 'terms' );
}
/**