From 798a3ba35ec3d30fd884fd9e6469eb21b724c9ca Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Tue, 13 Oct 2020 19:57:10 +0000 Subject: [PATCH] Administration: Restore alternative admin menu position for menu items with the same position value as an existing menu item. Reverts parts of [49108]. Props johnjamesjacoby. Fixes #42918. git-svn-id: https://develop.svn.wordpress.org/trunk@49138 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/plugin.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/wp-admin/includes/plugin.php b/src/wp-admin/includes/plugin.php index 29ecc3b402..ec791a3782 100644 --- a/src/wp-admin/includes/plugin.php +++ b/src/wp-admin/includes/plugin.php @@ -1347,11 +1347,10 @@ function add_menu_page( $page_title, $menu_title, $capability, $menu_slug, $func if ( null === $position ) { $menu[] = $new_menu; + } elseif ( isset( $menu[ "$position" ] ) ) { + $position = $position + substr( base_convert( md5( $menu_slug . $menu_title ), 16, 10 ), -5 ) * 0.00001; + $menu[ "$position" ] = $new_menu; } else { - if ( isset( $menu[ $position ] ) ) { - $position = $position + substr( base_convert( md5( $menu_slug . $menu_title ), 16, 10 ), -5 ) * 0.00001; - } - $menu[ $position ] = $new_menu; }