From 7ab6b096e630d7fb2e0b6f6f3a788989311d6099 Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Fri, 30 May 2014 16:58:36 +0000 Subject: [PATCH] Remove some dead variable assignments. See #27882. git-svn-id: https://develop.svn.wordpress.org/trunk@28629 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/class-wp-comments-list-table.php | 4 ++-- src/wp-admin/includes/class-wp-importer.php | 3 +-- src/wp-admin/includes/class-wp-posts-list-table.php | 5 ++--- src/wp-admin/includes/class-wp-terms-list-table.php | 1 - src/wp-admin/includes/class-wp-upgrader.php | 1 - 5 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/wp-admin/includes/class-wp-comments-list-table.php b/src/wp-admin/includes/class-wp-comments-list-table.php index cb474c3794..08b709b633 100644 --- a/src/wp-admin/includes/class-wp-comments-list-table.php +++ b/src/wp-admin/includes/class-wp-comments-list-table.php @@ -519,11 +519,11 @@ class WP_Comments_List_Table extends WP_List_Table { } } - public function column_date( $comment ) { + public function column_date() { return get_comment_date( __( 'Y/m/d \a\t g:ia' ) ); } - public function column_response( $comment ) { + public function column_response() { $post = get_post(); if ( isset( $this->pending_count[$post->ID] ) ) { diff --git a/src/wp-admin/includes/class-wp-importer.php b/src/wp-admin/includes/class-wp-importer.php index 77c769c71e..7f2a5e8949 100644 --- a/src/wp-admin/includes/class-wp-importer.php +++ b/src/wp-admin/includes/class-wp-importer.php @@ -196,10 +196,9 @@ class WP_Importer { /** * Bump up the request timeout for http requests * - * @param int $val * @return int */ - public function bump_request_timeout( $val ) { + public function bump_request_timeout() { return 60; } diff --git a/src/wp-admin/includes/class-wp-posts-list-table.php b/src/wp-admin/includes/class-wp-posts-list-table.php index d88aa16afc..60edd63e65 100644 --- a/src/wp-admin/includes/class-wp-posts-list-table.php +++ b/src/wp-admin/includes/class-wp-posts-list-table.php @@ -269,10 +269,9 @@ class WP_Posts_List_Table extends WP_List_Table { /* translators: manage posts column name */ $posts_columns['title'] = _x( 'Title', 'column name' ); - if ( post_type_supports( $post_type, 'author' ) ) + if ( post_type_supports( $post_type, 'author' ) ) { $posts_columns['author'] = __( 'Author' ); - - $taxonomies = array(); + } $taxonomies = get_object_taxonomies( $post_type, 'objects' ); $taxonomies = wp_filter_object_list( $taxonomies, array( 'show_admin_column' => true ), 'and', 'name' ); diff --git a/src/wp-admin/includes/class-wp-terms-list-table.php b/src/wp-admin/includes/class-wp-terms-list-table.php index f1d30b2676..61ab9d6b8a 100644 --- a/src/wp-admin/includes/class-wp-terms-list-table.php +++ b/src/wp-admin/includes/class-wp-terms-list-table.php @@ -189,7 +189,6 @@ class WP_Terms_List_Table extends WP_List_Table { foreach ( $terms as $term ) { $this->single_row( $term ); } - $count = $number; // Only displaying a single page. } } diff --git a/src/wp-admin/includes/class-wp-upgrader.php b/src/wp-admin/includes/class-wp-upgrader.php index ec39f6ad39..20f9e8658e 100644 --- a/src/wp-admin/includes/class-wp-upgrader.php +++ b/src/wp-admin/includes/class-wp-upgrader.php @@ -1919,7 +1919,6 @@ class WP_Automatic_Updater { * @param object $item The update offer. */ protected function send_core_update_notification_email( $item ) { - $notify = true; $notified = get_site_option( 'auto_core_update_notified' ); // Don't notify if we've already notified the same email address of the same version.