From 7cc095a1a05d612686221b1b6e37fd5d43130566 Mon Sep 17 00:00:00 2001 From: Helen Hou-Sandi Date: Thu, 6 Oct 2016 15:51:53 +0000 Subject: [PATCH] Login: Don't rely on `wp_is_mobile()` for functionality. Making behavior changes based on some broad definition of what mobile is rarely, if ever, makes sense. Each bit of functionality should be more clearly targeted, whether that's for screen size, performance, or some kind of touch capability. props akibjorklund. see #33704. git-svn-id: https://develop.svn.wordpress.org/trunk@38739 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/css/login.css | 19 ++++++------------- src/wp-login.php | 7 +------ 2 files changed, 7 insertions(+), 19 deletions(-) diff --git a/src/wp-admin/css/login.css b/src/wp-admin/css/login.css index 9f69e9c918..0a652d60da 100644 --- a/src/wp-admin/css/login.css +++ b/src/wp-admin/css/login.css @@ -216,19 +216,6 @@ p { width: 100%; } -.mobile #login { - padding: 20px 0; -} - -.mobile #login form { - margin-left: 0; -} - -.mobile #login #nav, -.mobile #login #backtoblog { - margin-left: 8px; -} - body.interim-login { height: auto; } @@ -255,6 +242,12 @@ body.interim-login { width: device-width; } +@media screen and ( max-height: 550px ) { + #login { + padding: 20px 0; + } +} + @media screen and ( max-width: 782px ) { .interim-login input[type=checkbox] { height: 16px; diff --git a/src/wp-login.php b/src/wp-login.php index 5266dd7b0a..b66bd6fb2d 100644 --- a/src/wp-login.php +++ b/src/wp-login.php @@ -36,8 +36,7 @@ function login_header( $title = 'Log In', $message = '', $wp_error = '' ) { // Don't index any of these forms add_action( 'login_head', 'wp_no_robots' ); - if ( wp_is_mobile() ) - add_action( 'login_head', 'wp_login_viewport_meta' ); + add_action( 'login_head', 'wp_login_viewport_meta' ); if ( empty($wp_error) ) $wp_error = new WP_Error(); @@ -124,8 +123,6 @@ function login_header( $title = 'Log In', $message = '', $wp_error = '' ) { $login_header_title = apply_filters( 'login_headertitle', $login_header_title ); $classes = array( 'login-action-' . $action, 'wp-core-ui' ); - if ( wp_is_mobile() ) - $classes[] = 'mobile'; if ( is_rtl() ) $classes[] = 'rtl'; if ( $interim_login ) { @@ -260,8 +257,6 @@ function login_footer($input_id = '') { * @since 3.0.0 */ function wp_shake_js() { - if ( wp_is_mobile() ) - return; ?>