sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Code Modernisation: Replace `call_user_func_array()` in `tests/phpunit/tests/db.php` with dynamic function calls. 

Props jrf.
See #47678.

git-svn-id: https://develop.svn.wordpress.org/trunk@46145 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2019-09-15 11:55:42 +00:00
parent 1ace25088f
commit 802c23e059
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/phpunit/tests/db.php
View File

@ -422,11 +422,8 @@ class Tests_DB extends WP_UnitTestCase {
public function test_prepare_incorrect_arg_count( $query, $args, $expected ) {
global $wpdb;
// $query is the first argument to be passed to wpdb::prepare()
array_unshift( $args, $query );
// phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
$prepared = @call_user_func_array( array( $wpdb, 'prepare' ), $args );
// phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged,WordPress.DB.PreparedSQL
$prepared = @$wpdb->prepare( $query, ...$args );
$this->assertEquals( $expected, $prepared );
}
@ -1366,9 +1363,8 @@ class Tests_DB extends WP_UnitTestCase {
$values = array( $values );
}
array_unshift( $values, $sql );
$sql = call_user_func_array( array( $wpdb, 'prepare' ), $values );
// phpcs:ignore WordPress.DB.PreparedSQL
$sql = $wpdb->prepare( $sql, ...$values );
$this->assertEquals( $expected, $sql );
}
@ -1386,7 +1382,8 @@ class Tests_DB extends WP_UnitTestCase {
$values = array( $values );
}
$sql = call_user_func_array( array( $wpdb, 'prepare' ), array( $sql, $values ) );
// phpcs:ignore WordPress.DB.PreparedSQL
$sql = $wpdb->prepare( $sql, $values );
$this->assertEquals( $expected, $sql );
}