From 805326cbd419cbc4da012dad60db83f2e2ffc4fb Mon Sep 17 00:00:00 2001 From: Jeremy Felt Date: Wed, 12 Dec 2018 03:07:58 +0000 Subject: [PATCH] Load: Disable PHP errors for JSON requests Because WP REST API requests aren't identified until `parse_request`, it's impractical to reference the `REST_REQUEST` constant in `wp_debug_mode()`. Instead, it's more helpful to assume that a request wanting a JSON response probably doesn't want PHP errors breaking the response. Merges [43730] to trunk. Props chrisl27, duanestorey, earnjam. Fixes #44534. git-svn-id: https://develop.svn.wordpress.org/trunk@43983 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/load.php | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/src/wp-includes/load.php b/src/wp-includes/load.php index 79e445021b..26fef7240a 100644 --- a/src/wp-includes/load.php +++ b/src/wp-includes/load.php @@ -349,7 +349,7 @@ function wp_debug_mode() { error_reporting( E_CORE_ERROR | E_CORE_WARNING | E_COMPILE_ERROR | E_ERROR | E_WARNING | E_PARSE | E_USER_ERROR | E_USER_WARNING | E_RECOVERABLE_ERROR ); } - if ( defined( 'XMLRPC_REQUEST' ) || defined( 'REST_REQUEST' ) || ( defined( 'WP_INSTALLING' ) && WP_INSTALLING ) || wp_doing_ajax() ) { + if ( defined( 'XMLRPC_REQUEST' ) || defined( 'REST_REQUEST' ) || ( defined( 'WP_INSTALLING' ) && WP_INSTALLING ) || wp_doing_ajax() || wp_is_json_request() ) { @ini_set( 'display_errors', 0 ); } } @@ -1250,3 +1250,24 @@ function wp_finalize_scraping_edited_file_errors( $scrape_key ) { } echo "\n###### wp_scraping_result_end:$scrape_key ######\n"; } + +/** + * Checks whether current request is a JSON request, or is expecting a JSON response. + * + * @since 5.0.0 + * + * @return bool True if Accepts or Content-Type headers contain application/json, false otherwise. + */ +function wp_is_json_request() { + + if ( isset( $_SERVER['HTTP_ACCEPT'] ) && false !== strpos( $_SERVER['HTTP_ACCEPT'], 'application/json' ) ) { + return true; + } + + if ( isset( $_SERVER['CONTENT_TYPE'] ) && 'application/json' === $_SERVER['CONTENT_TYPE'] ) { + return true; + } + + return false; + +}