From 81d90c0e442836d01c360e77a4373b084c36d117 Mon Sep 17 00:00:00 2001 From: John Blackbourn Date: Thu, 3 Mar 2016 03:24:02 +0000 Subject: [PATCH] Uploads: Remove an unnecessary static var from `wp_is_mobile()` to allow its direct and indirect use within unit tests. The static `$is_m obile` var was only used to avoid a handful of calls to `strpos()`, which are exceptionally fast and result in no measurable increase in processing time on each call to `wp_is_mobile()`. See #35976, #20014 git-svn-id: https://develop.svn.wordpress.org/trunk@36813 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/vars.php | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/wp-includes/vars.php b/src/wp-includes/vars.php index d894884c48..c903101997 100644 --- a/src/wp-includes/vars.php +++ b/src/wp-includes/vars.php @@ -120,17 +120,9 @@ $is_iis7 = $is_IIS && intval( substr( $_SERVER['SERVER_SOFTWARE'], strpos( $_SER /** * Test if the current browser runs on a mobile device (smart phone, tablet, etc.) * - * @staticvar bool $is_mobile - * * @return bool */ function wp_is_mobile() { - static $is_mobile = null; - - if ( isset( $is_mobile ) ) { - return $is_mobile; - } - if ( empty($_SERVER['HTTP_USER_AGENT']) ) { $is_mobile = false; } elseif ( strpos($_SERVER['HTTP_USER_AGENT'], 'Mobile') !== false // many mobile devices (all iPhone, iPad, etc.)