From 82e352e412c0595b191ccbdb5caaf2e1afb54c26 Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Mon, 18 Nov 2019 22:21:26 +0000 Subject: [PATCH] Accessibility: Media: Add an `aria-pressed` attribute to active button within a button group. The `aria-pressed` attribute communicates semantically the "active" state of buttons that otherwise only look "active". Fixes #48355. git-svn-id: https://develop.svn.wordpress.org/trunk@46748 602fd350-edb4-49c9-b593-d223f7449a82 --- src/js/media/views/settings.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/js/media/views/settings.js b/src/js/media/views/settings.js index 2469277c54..626a038e50 100644 --- a/src/js/media/views/settings.js +++ b/src/js/media/views/settings.js @@ -69,8 +69,12 @@ Settings = View.extend(/** @lends wp.media.view.Settings.prototype */{ // Handle button groups. } else if ( $setting.hasClass('button-group') ) { - $buttons = $setting.find('button').removeClass('active'); - $buttons.filter( '[value="' + value + '"]' ).addClass('active'); + $buttons = $setting.find( 'button' ) + .removeClass( 'active' ) + .attr( 'aria-pressed', 'false' ); + $buttons.filter( '[value="' + value + '"]' ) + .addClass( 'active' ) + .attr( 'aria-pressed', 'true' ); // Handle text inputs and textareas. } else if ( $setting.is('input[type="text"], textarea') ) {