sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Embeds: Rename the $return parameter in wp_filter_oembed_result() to $result to provide better context on what is being filtered.

Browse Source 
See #32522.


git-svn-id: https://develop.svn.wordpress.org/trunk@34974 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Drew Jaynes 2015-10-08 23:21:49 +00:00
parent 8a7f8602b3
commit 85d0dfc45c
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/wp-includes/embed-functions.php
View File

@ -679,21 +679,21 @@ function _oembed_create_xml( $data, $node = null ) {
/**
* Filters the given oEmbed HTML.
*
* If the $url isn't on the trusted providers list,
* If the `$url` isn't on the trusted providers list,
* we need to filter the HTML heavily for security.
*
* Only filters 'rich' and 'html' response types.
*
* @since 4.4.0
*
* @param string $return The returned oEmbed HTML.
* @param string $result The oEmbed HTML result.
* @param object $data A data object result from an oEmbed provider.
* @param string $url The URL of the content to be embedded.
* @return string The filtered and sanitized oEmbed result.
*/
function wp_filter_oembed_result( $return, $data, $url ) {
if ( false === $return || ! in_array( $data->type, array( 'rich', 'video' ) ) ) {
return $return;
function wp_filter_oembed_result( $result, $data, $url ) {
if ( false === $result || ! in_array( $data->type, array( 'rich', 'video' ) ) ) {
return $result;
}
require_once( ABSPATH . WPINC . '/class-oembed.php' );
@ -701,7 +701,7 @@ function wp_filter_oembed_result( $return, $data, $url ) {
// Don't modify the HTML for trusted providers.
if ( false !== $wp_oembed->get_provider( $url, array( 'discover' => false ) ) ) {
return $return;
return $result;
}
$allowed_html = array(
@ -718,7 +718,7 @@ function wp_filter_oembed_result( $return, $data, $url ) {
),
);
$html = wp_kses( $return, $allowed_html );
$html = wp_kses( $result, $allowed_html );
preg_match( '|^.*(<iframe.*?></iframe>).*$|m', $html, $iframes );
if ( empty( $iframes ) ) {