sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Security: Remove unnecessary DISABLE_WP_CRON check in plugin and theme automatic updates.

Browse Source 
Fixes #50436.

Props johnbillion, audrasjb, bookdude13, pbiron, arpitgshah.




git-svn-id: https://develop.svn.wordpress.org/trunk@48147 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jake Spurlock 2020-06-23 22:22:33 +00:00
parent 2e276f354b
commit 86162510c5
1 changed files with 20 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
src/wp-admin/includes/update.php
View File

@ -984,30 +984,26 @@ function wp_get_auto_update_message() {
// Check if event exists.
if ( false === $next_update_time ) {
return __( 'There may be a problem with WP-Cron. Automatic update not scheduled.' );
}
// See if cron is disabled
$cron_disabled = defined( 'DISABLE_WP_CRON' ) && DISABLE_WP_CRON;
if ( $cron_disabled ) {
return __( 'WP-Cron is disabled. Automatic updates not available.' );
}
$time_to_next_update = human_time_diff( intval( $next_update_time ) );
// See if cron is overdue.
$overdue = ( time() - $next_update_time ) > 0;
if ( $overdue ) {
return sprintf(
/* translators: Duration that WP-Cron has been overdue. */
__( 'There may be a problem with WP-Cron. Automatic update overdue by %s.' ),
$time_to_next_update
);
$message = __( 'Auto-update update not scheduled. There may be a problem with WP-Cron.' );
} else {
return sprintf(
/* translators: Time until the next update. */
__( 'Auto-update scheduled in %s.' ),
$time_to_next_update
);
$time_to_next_update = human_time_diff( intval( $next_update_time ) );
// See if cron is overdue.
$overdue = ( time() - $next_update_time ) > 0;
if ( $overdue ) {
$message = sprintf(
/* translators: Duration that WP-Cron has been overdue. */
__( 'Auto-update update overdue by %s. There may be a problem with WP-Cron.' ),
$time_to_next_update
);
} else {
$message = sprintf(
/* translators: Time until the next update. */
__( 'Auto-update update scheduled in %s.' ),
$time_to_next_update
);
}
}
return $message;
}