From 874e6afdcaae279a198531560cbc27b92d8fe052 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Wed, 22 Jul 2020 00:13:21 +0000 Subject: [PATCH] Site Health: Correct inverted logic for themes in the test for plugin and theme auto-updates. Follow-up to [48548], [48558]. See #50662. git-svn-id: https://develop.svn.wordpress.org/trunk@48559 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/class-wp-site-health.php | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/wp-admin/includes/class-wp-site-health.php b/src/wp-admin/includes/class-wp-site-health.php index e3c470d9f5..92d37183df 100644 --- a/src/wp-admin/includes/class-wp-site-health.php +++ b/src/wp-admin/includes/class-wp-site-health.php @@ -2319,9 +2319,9 @@ class WP_Site_Health { foreach ( $this->crons as $id => $cron ) { $cron_offset = $cron->time - time(); if ( - $cron_offset >= $this->timeout_missed_cron && - $cron_offset < $this->timeout_late_cron - ) { + $cron_offset >= $this->timeout_missed_cron && + $cron_offset < $this->timeout_late_cron + ) { $this->last_late_cron = $cron->hook; return true; } @@ -2349,14 +2349,18 @@ class WP_Site_Health { $plugin_filter_present = has_filter( 'auto_update_plugin' ); $theme_filter_present = has_filter( 'auto_update_theme' ); - if ( ( ! $test_plugins_enabled && $ui_enabled_for_plugins ) || ( $test_themes_enabled && $ui_enabled_for_themes ) ) { + if ( ( ! $test_plugins_enabled && $ui_enabled_for_plugins ) + || ( ! $test_themes_enabled && $ui_enabled_for_themes ) + ) { return (object) array( 'status' => 'critical', 'message' => __( 'Auto-updates for plugins and/or themes appear to be disabled, but settings are still set to be displayed. This could cause auto-updates to not work as expected.' ), ); } - if ( ( ! $test_plugins_enabled && $plugin_filter_present ) && ( ! $test_themes_enabled && $theme_filter_present ) ) { + if ( ( ! $test_plugins_enabled && $plugin_filter_present ) + && ( ! $test_themes_enabled && $theme_filter_present ) + ) { return (object) array( 'status' => 'recommended', 'message' => __( 'Auto-updates for plugins and themes appear to be disabled. This will prevent your sites from receiving new versions automatically when available.' ),