sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Date/Time: In `wp_insert_post()`, when checking the post date to set `future` or `publish` status, use string comparison to work around far future dates (year 2038+) on 32-bit systems. 

Props Rarst, nofearinc.
Fixes #25347.

git-svn-id: https://develop.svn.wordpress.org/trunk@45851 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2019-08-19 15:49:32 +00:00
parent 0f8ba2cf2a
commit 896da178e0
2 changed files with 26 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/wp-includes/post.php
View File

@ -3663,14 +3663,13 @@ function wp_insert_post( $postarr, $wp_error = false ) {
}
if ( 'attachment' !== $post_type ) {
if ( 'publish' == $post_status ) {
$now = gmdate( 'Y-m-d H:i:59' );
if ( mysql2date( 'U', $post_date_gmt, false ) > mysql2date( 'U', $now, false ) ) {
if ( 'publish' === $post_status ) {
// String comparison to work around far future dates (year 2038+) on 32-bit systems.
if ( $post_date_gmt > gmdate( 'Y-m-d H:i:59' ) ) {
$post_status = 'future';
}
} elseif ( 'future' == $post_status ) {
$now = gmdate( 'Y-m-d H:i:59' );
if ( mysql2date( 'U', $post_date_gmt, false ) <= mysql2date( 'U', $now, false ) ) {
} elseif ( 'future' === $post_status ) {
if ( $post_date_gmt <= gmdate( 'Y-m-d H:i:59' ) ) {
$post_status = 'publish';
}
}

21
tests/phpunit/tests/post/wpInsertPost.php
View File

@ -302,4 +302,25 @@ class Tests_WPInsertPost extends WP_UnitTestCase {
$this->assertSame( $expected, $actual );
}
/**
* @ticket 25347
*/
function test_scheduled_post_with_a_past_date_should_be_published() {
$now = new DateTimeImmutable( 'now', new DateTimeZone( 'UTC' ) );
$post_id = $this->factory()->post->create( [
'post_date_gmt' => $now->modify( '-1 year' )->format( 'Y-m-d H:i:s' ),
'post_status' => 'future',
] );
$this->assertEquals( 'publish', get_post_status( $post_id ) );
$post_id = $this->factory()->post->create( [
'post_date_gmt' => $now->modify( '+50 years' )->format( 'Y-m-d H:i:s' ),
'post_status' => 'future',
] );
$this->assertEquals( 'future', get_post_status( $post_id ) );
}
}