sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

In `update_meta_cache()`, ensure that meta is always stored in the same order. Removes an unnecessary `$wpdb->prepare` statement. Adds unit test. 

Props mattheu.
Fixes #25511.



git-svn-id: https://develop.svn.wordpress.org/trunk@26307 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor 2013-11-21 19:30:35 +00:00
parent 3341352a3d
commit 926427e9ee
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/wp-includes/meta.php
View File

@ -558,9 +558,9 @@ function update_meta_cache($meta_type, $object_ids) {
return $cache;
// Get meta info
$id_list = join(',', $ids);
$meta_list = $wpdb->get_results( $wpdb->prepare("SELECT $column, meta_key, meta_value FROM $table WHERE $column IN ($id_list)",
$meta_type), ARRAY_A );
$id_list = join( ',', $ids );
$id_column = 'user' == $meta_type ? 'umeta_id' : 'meta_id';
$meta_list = $wpdb->get_results( "SELECT $column, meta_key, meta_value FROM $table WHERE $column IN ($id_list) ORDER BY $id_column ASC", ARRAY_A );
if ( !empty($meta_list) ) {
foreach ( $meta_list as $metarow) {

15
tests/phpunit/tests/meta.php
View File

@ -171,4 +171,19 @@ class Tests_Meta extends WP_UnitTestCase {
$this->assertEquals( array( $post_id2, $post_id1 ), $posts->posts );
$this->assertEquals( 2, substr_count( $posts->request, 'CAST(' ) );
}
function test_meta_cache_order_asc() {
$post_id = $this->factory->post->create();
$colors = array( 'red', 'blue', 'yellow', 'green' );
foreach ( $colors as $color )
add_post_meta( $post_id, 'color', $color );
foreach ( range( 1, 10 ) as $i ) {
$meta = get_post_meta( $post_id, 'color' );
$this->assertEquals( $meta, $colors );
if ( 0 === $i % 2 )
wp_cache_delete( $post_id, 'post_meta' );
}
}
}