From 953e094719fcae7f6f1200ad5d0730829e414adc Mon Sep 17 00:00:00 2001 From: Ian Dunn Date: Mon, 30 Apr 2018 18:52:59 +0000 Subject: [PATCH] Privacy: Use a CSPRNG in export filenames for more security. `rand()` is deterministic and therefore offers much less protection in this context. `wp_generate_password()` is a convenient wrapper around `wp_rand()`, which uses `random_int()` to generate cryptographically-secure psuedorandom numbers. See #43546. git-svn-id: https://develop.svn.wordpress.org/trunk@43045 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/file.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-admin/includes/file.php b/src/wp-admin/includes/file.php index 8c8d6bc8d2..21a44a6135 100644 --- a/src/wp-admin/includes/file.php +++ b/src/wp-admin/includes/file.php @@ -2042,7 +2042,7 @@ function wp_privacy_generate_personal_data_export_file( $request_id ) { $stripped_email = str_replace( '@', '-at-', $email_address ); $stripped_email = sanitize_title( $stripped_email ); // slugify the email address - $obscura = md5( rand() ); + $obscura = wp_generate_password( 32, false, false ); $file_basename = 'wp-personal-data-file-' . $stripped_email . '-' . $obscura; $html_report_filename = $file_basename . '.html'; $html_report_pathname = $exports_dir . $html_report_filename;