Twenty Fifteen: JSHint fixes.

* Define global variables set by wp_localize_script().
 * Remove currently unused $ variable.
 * Use dot notation when appropriate.
 * Update Gruntfile.js to ignore the html5 shiv.
see #29799.


git-svn-id: https://develop.svn.wordpress.org/trunk@29893 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Andrew Nacin 2014-10-14 19:47:11 +00:00
parent af4fdd7f81
commit 9966625f84
3 changed files with 25 additions and 23 deletions

View File

@ -218,7 +218,7 @@ module.exports = function(grunt) {
'twenty*/**/*.js', 'twenty*/**/*.js',
'!twenty{eleven,twelve,thirteen}/**', '!twenty{eleven,twelve,thirteen}/**',
// Third party scripts // Third party scripts
'!twentyfourteen/js/html5.js' '!twenty{fourteen,fifteen}/js/html5.js'
] ]
}, },
core: { core: {

View File

@ -1,10 +1,11 @@
/* global colorScheme */
/** /**
* Theme Customizer enhancements for a better user experience. * Theme Customizer enhancements for a better user experience.
* *
* Adds listener to Color Scheme control to update other color controls with new values/defaults * Adds listener to Color Scheme control to update other color controls with new values/defaults
*/ */
( function( wp, $ ) { ( function( wp ) {
wp.customize.controlConstructor.colorScheme = wp.customize.Control.extend( { wp.customize.controlConstructor.colorScheme = wp.customize.Control.extend( {
ready: function() { ready: function() {
var parentSection = this.container.closest( '.control-section' ), var parentSection = this.container.closest( '.control-section' ),
@ -16,34 +17,34 @@
this.setting.bind( 'change', function( value ) { this.setting.bind( 'change', function( value ) {
// if Header Text is not hidden, update value // if Header Text is not hidden, update value
if ( 'blank' !== wp.customize( 'header_textcolor' ).get() ) { if ( 'blank' !== wp.customize( 'header_textcolor' ).get() ) {
wp.customize( 'header_textcolor' ).set( colorScheme[value]['colors'][4] ); wp.customize( 'header_textcolor' ).set( colorScheme[value].colors[4] );
headerTextColor.val( colorScheme[value]['colors'][4] ) headerTextColor.val( colorScheme[value].colors[4] )
.data( 'data-default-color', colorScheme[value]['colors'][4] ) .data( 'data-default-color', colorScheme[value].colors[4] )
.wpColorPicker( 'color', colorScheme[value]['colors'][4] ) .wpColorPicker( 'color', colorScheme[value].colors[4] )
.wpColorPicker( 'defaultColor', colorScheme[value]['colors'][4] ); .wpColorPicker( 'defaultColor', colorScheme[value].colors[4] );
} }
// update Background Color // update Background Color
wp.customize( 'background_color' ).set( colorScheme[value]['colors'][0] ); wp.customize( 'background_color' ).set( colorScheme[value].colors[0] );
backgroundColor.val( colorScheme[value]['colors'][0] ) backgroundColor.val( colorScheme[value].colors[0] )
.data( 'data-default-color', colorScheme[value]['colors'][0] ) .data( 'data-default-color', colorScheme[value].colors[0] )
.wpColorPicker( 'color', colorScheme[value]['colors'][0] ) .wpColorPicker( 'color', colorScheme[value].colors[0] )
.wpColorPicker( 'defaultColor', colorScheme[value]['colors'][0] ); .wpColorPicker( 'defaultColor', colorScheme[value].colors[0] );
// update Header/Sidebar Background Color // update Header/Sidebar Background Color
wp.customize( 'header_background_color' ).set( colorScheme[value]['colors'][1] ); wp.customize( 'header_background_color' ).set( colorScheme[value].colors[1] );
sidebarColor.val( colorScheme[value]['colors'][1] ) sidebarColor.val( colorScheme[value].colors[1] )
.data( 'data-default-color', colorScheme[value]['colors'][1] ) .data( 'data-default-color', colorScheme[value].colors[1] )
.wpColorPicker( 'color', colorScheme[value]['colors'][1] ) .wpColorPicker( 'color', colorScheme[value].colors[1] )
.wpColorPicker( 'defaultColor', colorScheme[value]['colors'][1] ); .wpColorPicker( 'defaultColor', colorScheme[value].colors[1] );
// update Sidebar Text Color // update Sidebar Text Color
wp.customize( 'sidebar_textcolor' ).set( colorScheme[value]['colors'][4] ); wp.customize( 'sidebar_textcolor' ).set( colorScheme[value].colors[4] );
sidebarTextColor.val( colorScheme[value]['colors'][4] ) sidebarTextColor.val( colorScheme[value].colors[4] )
.data( 'data-default-color', colorScheme[value]['colors'][4] ) .data( 'data-default-color', colorScheme[value].colors[4] )
.wpColorPicker( 'color', colorScheme[value]['colors'][4] ) .wpColorPicker( 'color', colorScheme[value].colors[4] )
.wpColorPicker( 'defaultColor', colorScheme[value]['colors'][4] ); .wpColorPicker( 'defaultColor', colorScheme[value].colors[4] );
} ); } );
} }
} ); } );
} )( this.wp, jQuery ); } )( this.wp );

View File

@ -1,3 +1,4 @@
/* global screenReaderText */
/** /**
* Theme functions file * Theme functions file
* *