From 9d4b0ec88f1753bd360119c65ff14a0ec4b53396 Mon Sep 17 00:00:00 2001 From: obenland Date: Thu, 19 Jul 2018 21:59:23 +0000 Subject: [PATCH] Toolbar: Fail gracefully when adding events to non-existent elements Avoids a type error when `obj` is not set. Fixes #44526. git-svn-id: https://develop.svn.wordpress.org/trunk@43517 602fd350-edb4-49c9-b593-d223f7449a82 --- src/js/_enqueues/lib/admin-bar.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/js/_enqueues/lib/admin-bar.js b/src/js/_enqueues/lib/admin-bar.js index 629caac645..005bdbe096 100644 --- a/src/js/_enqueues/lib/admin-bar.js +++ b/src/js/_enqueues/lib/admin-bar.js @@ -303,10 +303,13 @@ if ( typeof(jQuery) != 'undefined' ) { * @return {void} */ var addEvent = function( obj, type, fn ) { - if ( obj.addEventListener ) - obj.addEventListener(type, fn, false); - else if ( obj.attachEvent ) - obj.attachEvent('on' + type, function() { return fn.call(obj, window.event);}); + if ( typeof obj.addEventListener === 'function' ) { + obj.addEventListener( type, fn, false ); + } else if ( typeof obj.attachEvent === 'function' ) { + obj.attachEvent( 'on' + type, function() { + return fn.call( obj, window.event ); + } ); + } }, aB, hc = new RegExp('\\bhover\\b', 'g'), q = [],