sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

In `get_terms()`, allow terms to be ordered by 'term_id'. 

[29128] introduced updated documentation for the `'orderby'` parameter of
`get_terms()`. The new documentation mistakenly said that 'term_id' was a valid
orderby value. The current changeset makes that fantasy...A REALITY.

Props ixkaito.
Fixes #33726.

git-svn-id: https://develop.svn.wordpress.org/trunk@33903 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges 2015-09-04 21:16:11 +00:00
parent dfceba6d05
commit 9dfc5551ee
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/wp-includes/taxonomy-functions.php
View File

@ -945,6 +945,7 @@ function get_term_to_edit( $id, $taxonomy ) {
*
* @since 2.3.0
* @since 4.2.0 Introduced 'name' and 'childless' parameters.
* @since 4.4.0 Introduced the ability to pass 'term_id' as an alias of 'id' for the `orderby` parameter.
*
* @global wpdb $wpdb WordPress database abstraction object.
* @global array $wp_filter
@ -1132,7 +1133,7 @@ function get_terms( $taxonomies, $args = '' ) {
$orderby = 'tt.description';
} elseif ( 'none' == $_orderby ) {
$orderby = '';
} elseif ( empty($_orderby) || 'id' == $_orderby ) {
} elseif ( empty( $_orderby ) || 'id' == $_orderby || 'term_id' === $_orderby ) {
$orderby = 't.term_id';
} else {
$orderby = 't.name';

27
tests/phpunit/tests/term/getTerms.php
View File

@ -1186,6 +1186,33 @@ class Tests_Term_getTerms extends WP_UnitTestCase {
$this->assertEquals( array( $t2, $t1, $t4, $t3 ), $found );
}
/**
* @ticket 33726
*/
public function test_orderby_term_id() {
register_taxonomy( 'wptests_tax', 'post' );
$t1 = $this->factory->term->create( array(
'taxonomy' => 'wptests_tax',
'name' => 'AAA',
) );
$t2 = $this->factory->term->create( array(
'taxonomy' => 'wptests_tax',
'name' => 'ZZZ',
) );
$t3 = $this->factory->term->create( array(
'taxonomy' => 'wptests_tax',
'name' => 'JJJ',
) );
$found = get_terms( 'wptests_tax', array(
'orderby' => 'term_id',
'hide_empty' => false,
'fields' => 'ids',
) );
$this->assertEquals( array( $t1, $t2, $t3 ), $found );
}
public function test_hierarchical_false_with_parent() {
$initial_terms = $this->create_hierarchical_terms();