sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Posts: Don't modify post_name if it wasn't supplied to wp_insert_post().

Browse Source 
Previously when updating a post using wp_insert_post(), post_name was 
regenerated based on post_title every time if post_name was not passed in 
explicitly. This irons out the expectation that properties not passed into the 
function should not be modified.

Props jason_the_adams. 
Fixes #34865.


git-svn-id: https://develop.svn.wordpress.org/trunk@35800 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Eric Andrew Lewis 2015-12-06 21:57:59 +00:00
parent 171ae0f20d
commit a84227aab7
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/wp-includes/post.php
View File

@ -2872,7 +2872,8 @@ function wp_get_recent_posts( $args = array(), $output = ARRAY_A ) {
* @type string $ping_status Whether the post can accept pings. Accepts 'open' or 'closed'. * @type string $ping_status Whether the post can accept pings. Accepts 'open' or 'closed'.
* Default is the value of 'default_ping_status' option. * Default is the value of 'default_ping_status' option.
* @type string $post_password The password to access the post. Default empty. * @type string $post_password The password to access the post. Default empty.
* @type string $post_name The post name. Default is the sanitized post title. * @type string $post_name The post name. Default is the sanitized post title
* when creating a new post.
* @type string $to_ping Space or carriage return-separated list of URLs to ping. * @type string $to_ping Space or carriage return-separated list of URLs to ping.
* Default empty. * Default empty.
* @type string $pinged Space or carriage return-separated list of URLs that have * @type string $pinged Space or carriage return-separated list of URLs that have
@ -2953,6 +2954,9 @@ function wp_insert_post( $postarr, $wp_error = false ) {
$post_excerpt = $postarr['post_excerpt']; $post_excerpt = $postarr['post_excerpt'];
if ( isset( $postarr['post_name'] ) ) { if ( isset( $postarr['post_name'] ) ) {
$post_name = $postarr['post_name']; $post_name = $postarr['post_name'];
} elseif ( $update ) {
// For an update, don't modify the post_name if it wasn't supplied as an argument.
$post_name = $post_before->post_name;
} }
$maybe_empty = 'attachment' !== $post_type $maybe_empty = 'attachment' !== $post_type

24
tests/phpunit/tests/post.php
View File

@ -1188,6 +1188,30 @@ class Tests_Post extends WP_UnitTestCase {
$this->assertEquals( 'Updated', $saved_post->post_content ); $this->assertEquals( 'Updated', $saved_post->post_content );
} }
/**
* If a post is updated without providing a post_name param,
* a new slug should not be generated.
*
* @ticket 34865
*/
function test_post_updates_without_slug_provided() {
$post_id = self::factory()->post->create( array(
'post_title' => 'Stuff',
'post_status' => 'publish'
) );
$data = array(
'ID' => $post_id,
'post_title' => 'Stuff and Things'
);
wp_insert_post( $data );
$updated_post = get_post( $post_id );
// Ensure changing the post_title didn't modify the post_name.
$this->assertEquals('stuff', $updated_post->post_name);
}
/** /**
* @ticket 32585 * @ticket 32585
*/ */