From aae789324ff1998767eeee9419884cbb2ed49839 Mon Sep 17 00:00:00 2001
From: Sergey Biryukov <sergeybiryukov@git.wordpress.org>
Date: Thu, 28 Mar 2019 16:14:03 +0000
Subject: [PATCH] Site Health: Add description for a successful HTTPS check.

Props Clorith, xkon.
Fixes #46617.

git-svn-id: https://develop.svn.wordpress.org/trunk@45052 602fd350-edb4-49c9-b593-d223f7449a82
---
 .../includes/class-wp-site-health.php         | 40 ++++++++-----------
 1 file changed, 16 insertions(+), 24 deletions(-)

diff --git a/src/wp-admin/includes/class-wp-site-health.php b/src/wp-admin/includes/class-wp-site-health.php
index d5cd8a980c..d7e9f82f08 100644
--- a/src/wp-admin/includes/class-wp-site-health.php
+++ b/src/wp-admin/includes/class-wp-site-health.php
@@ -1202,14 +1202,24 @@ class WP_Site_Health {
 	 */
 	public function get_test_https_status() {
 		$result = array(
-			'label'       => '',
-			'status'      => '',
+			'label'       => __( 'Your website is using an active HTTPS connection.' ),
+			'status'      => 'good',
 			'badge'       => array(
 				'label' => 'Security',
 				'color' => 'red',
 			),
-			'description' => '',
-			'actions'     => '',
+			'description' => sprintf(
+				'<p>%s</p>',
+				__( 'An HTTPS connection is needed for many features on the web today, it also gains the trust of your visitors by helping to protecting their online privacy.' )
+			),
+			'actions'     => sprintf(
+				'<p><a href="%s">%s</a></p>',
+				esc_url(
+					/* translators: Website for explaining HTTPS and why it should be used. */
+					__( 'https://wordpress.org/support/article/why-should-i-use-https/' )
+				),
+				__( 'Read more about why you should use HTTPS' )
+			),
 			'test'        => 'https_status',
 		);
 
@@ -1231,34 +1241,16 @@ class WP_Site_Health {
 					)
 				);
 
-				$result['actions'] = sprintf(
-					'<a href="%s">%s</a>',
+				$result['actions'] .= sprintf(
+					'<p><a href="%s">%s</a></p>',
 					esc_url( admin_url( 'options-general.php' ) ),
 					__( 'Update your site addresses' )
 				);
-			} else {
-				$result['status'] = 'good';
-
-				$result['label'] = __( 'Your website is using an active HTTPS connection.' );
 			}
 		} else {
 			$result['status'] = 'recommended';
 
 			$result['label'] = __( 'Your site does not use HTTPS' );
-
-			$result['description'] = sprintf(
-				'<p>%s</p>',
-				__( 'An HTTPS connection is needed for many features on the web today, it also gains the trust of your visitors by helping to protecting their online privacy.' )
-			);
-
-			$result['actions'] = sprintf(
-				'<a href="%s">%s</a>',
-				esc_url(
-					/* translators: Website for explaining HTTPS and why it should be used. */
-					__( 'https://wordpress.org/support/article/why-should-i-use-https/' )
-				),
-				__( 'Read more about why you should use HTTPS.' )
-			);
 		}
 
 		return $result;