sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Tests: Introduce WP_UnitTestCase::reset_permalinks(), an attempt to DRY up logic for resetting and restoring default permalinks on setUp() and tearDown().

Browse Source 
See #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@34802 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Drew Jaynes 2015-10-03 17:14:12 +00:00
parent 4fc732d804
commit adffdab161
18 changed files with 56 additions and 245 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/phpunit/includes/testcase-canonical.php
View File

@ -16,17 +16,18 @@ class WP_Canonical_UnitTestCase extends WP_UnitTestCase {
public $structure = '/%year%/%monthnum%/%day%/%postname%/';
public function setUp() {
global $wp_rewrite;
parent::setUp();
update_option( 'page_comments', true );
update_option( 'comments_per_page', 5 );
update_option( 'posts_per_page', 5 );
global $wp_rewrite;
$wp_rewrite->init();
$wp_rewrite->set_permalink_structure( $this->structure );
create_initial_taxonomies();
$wp_rewrite->flush_rules();
}

34
tests/phpunit/includes/testcase.php
View File

@ -16,6 +16,8 @@ class WP_UnitTestCase extends PHPUnit_Framework_TestCase {
protected $db_version;
public static $default_permalink_structure;
/**
* @var WP_UnitTest_Factory
*/
@ -70,6 +72,10 @@ class WP_UnitTestCase extends PHPUnit_Framework_TestCase {
if ( is_multisite() ) {
add_filter( 'pre_option_db_version', array( $this, 'db_version' ) );
}
self::$default_permalink_structure = get_option( 'permalink_structure' );
$this->reset_permalinks();
}
/**
@ -99,6 +105,8 @@ class WP_UnitTestCase extends PHPUnit_Framework_TestCase {
remove_filter( 'wp_die_handler', array( $this, 'get_wp_die_handler' ) );
$this->_restore_hooks();
wp_set_current_user( 0 );
$this->reset_permalinks( $restore = true );
}
function clean_up_global_scope() {
@ -645,4 +653,30 @@ class WP_UnitTestCase extends PHPUnit_Framework_TestCase {
public function db_version() {
return $this->db_version;
}
/**
* Utility method that resets permalinks and flushes rewrites.
*
* Collects the current permalink structure and stores it in a class property for use
* by sub-classes.
*
* @since 4.4.0
*
* @global WP_Rewrite $wp_rewrite
*
* @param bool $restore_default Optional. Whether to restore the default permalink structure.
* Default false.
*/
public function reset_permalinks( $restore_default = false ) {
global $wp_rewrite;
if ( ! $restore_default ) {
$wp_rewrite->init();
$wp_rewrite->set_permalink_structure( '' );
} else {
$wp_rewrite->set_permalink_structure( self::$default_permalink_structure );
}
$wp_rewrite->flush_rules();
}
}

2
tests/phpunit/includes/utils.php
View File

@ -447,4 +447,4 @@ function benchmark_pcre_backtracking( $pattern, $subject, $strategy ) {
}
return $i;
}
}

44
tests/phpunit/tests/admin/includesPost.php
View File

@ -253,7 +253,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
public function test_get_sample_permalink_should_return_pretty_permalink_for_posts_with_post_status_future() {
global $wp_rewrite;
$old_permalink_structure = get_option( 'permalink_structure' );
$permalink_structure = '%postname%';
$wp_rewrite->set_permalink_structure( "/$permalink_structure/" );
flush_rewrite_rules();
@ -265,9 +264,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$expected = trailingslashit( home_url( $permalink_structure ) );
$this->assertSame( $expected, $found[0] );
$wp_rewrite->set_permalink_structure( $old_permalink_structure );
flush_rewrite_rules();
}
/**
@ -275,11 +271,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
* @ticket 18306
*/
public function test_get_sample_permalink_html_should_use_default_permalink_for_view_post_link_when_pretty_permalinks_are_disabled() {
global $wp_rewrite;
$old_permalink_structure = get_option( 'permalink_structure' );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
wp_set_current_user( $this->factory->user->create( array( 'role' => 'administrator' ) ) );
$future_date = date( 'Y-m-d H:i:s', time() + 100 );
@ -287,9 +278,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$found = get_sample_permalink_html( $p );
$this->assertContains( 'href="' . get_option( 'home' ) . '/?p=' . $p . '"', $found );
$wp_rewrite->set_permalink_structure( $old_permalink_structure );
flush_rewrite_rules();
}
/**
@ -298,7 +286,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
*/
public function test_get_sample_permalink_html_should_use_pretty_permalink_for_view_post_link_when_pretty_permalinks_are_enabled() {
global $wp_rewrite;
$old_permalink_structure = get_option( 'permalink_structure' );
$permalink_structure = '%postname%';
$wp_rewrite->set_permalink_structure( "/$permalink_structure/" );
flush_rewrite_rules();
@ -311,9 +298,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$found = get_sample_permalink_html( $p );
$post = get_post( $p );
$this->assertContains( 'href="' . get_option( 'home' ) . "/" . $post->post_name . '/"', $found );
$wp_rewrite->set_permalink_structure( $old_permalink_structure );
flush_rewrite_rules();
}
/**
@ -322,7 +306,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
*/
public function test_get_sample_permalink_html_should_use_correct_permalink_for_view_post_link_when_changing_slug() {
global $wp_rewrite;
$old_permalink_structure = get_option( 'permalink_structure' );
$permalink_structure = '%postname%';
$wp_rewrite->set_permalink_structure( "/$permalink_structure/" );
flush_rewrite_rules();
@ -357,9 +340,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$preview_link = add_query_arg( 'preview', 'true', $preview_link );
$this->assertContains( 'href="' . esc_url( $preview_link ) . '"', $found, $message );
$wp_rewrite->set_permalink_structure( $old_permalink_structure );
flush_rewrite_rules();
}
/**
@ -377,9 +357,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$found = get_sample_permalink( $p );
$this->assertEquals( '2015-2', $found[1] );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -397,9 +374,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$found = get_sample_permalink( $p );
$this->assertEquals( '2015', $found[1] );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -417,9 +391,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$found = get_sample_permalink( $p );
$this->assertEquals( '11-2', $found[1] );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -437,9 +408,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$found = get_sample_permalink( $p );
$this->assertEquals( '13', $found[1] );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -457,9 +425,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$found = get_sample_permalink( $p );
$this->assertEquals( '30-2', $found[1] );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -481,9 +446,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$found = get_sample_permalink( $p );
$this->assertEquals( '30-3', $found[1] );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -501,9 +463,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$found = get_sample_permalink( $p );
$this->assertEquals( '32', $found[1] );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -521,9 +480,6 @@ class Tests_Admin_includesPost extends WP_UnitTestCase {
$found = get_sample_permalink( $p );
$this->assertEquals( '30', $found[1] );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
public function test_post_exists_should_match_title() {

7
tests/phpunit/tests/comment/commentsTemplate.php
View File

@ -6,13 +6,6 @@
* Testing items that are only testable by grabbing the markup of `comments_template()` from the output buffer.
*/
class Tests_Comment_CommentsTemplate extends WP_UnitTestCase {
public function setUp() {
parent::setUp();
global $wp_rewrite;
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
* @ticket 8071

13
tests/phpunit/tests/feed/rss2.php
View File

@ -9,8 +9,6 @@
* @group feed
*/
class Tests_Feed_RSS2 extends WP_UnitTestCase {
private $permalink_structure = '';
static $user;
static $posts;
@ -40,11 +38,6 @@ class Tests_Feed_RSS2 extends WP_UnitTestCase {
}
public function setUp() {
global $wp_rewrite;
$this->permalink_structure = get_option( 'permalink_structure' );
$wp_rewrite->set_permalink_structure( '' );
$wp_rewrite->flush_rules();
parent::setUp();
$this->post_count = get_option('posts_per_rss');
@ -53,12 +46,6 @@ class Tests_Feed_RSS2 extends WP_UnitTestCase {
update_option('use_smilies', false);
}
public function tearDown() {
global $wp_rewrite;
$wp_rewrite->set_permalink_structure( $this->permalink_structure );
$wp_rewrite->flush_rules();
}
function do_rss2() {
ob_start();
// nasty hack

10
tests/phpunit/tests/general/paginateLinks.php
View File

@ -3,21 +3,11 @@
class Tests_Paginate_Links extends WP_UnitTestCase {
private $i18n_count = 0;
private $permalink_structure = '';
function setUp() {
parent::setUp();
global $wp_rewrite;
$this->go_to( home_url( '/' ) );
$this->permalink_structure = $wp_rewrite->permalink_structure;
$wp_rewrite->set_permalink_structure( get_option( 'permalink_structure' ) );
}
function tearDown() {
global $wp_rewrite;
$wp_rewrite->set_permalink_structure( $this->permalink_structure );
}
function test_defaults() {

4
tests/phpunit/tests/link.php
View File

@ -40,10 +40,6 @@ class Tests_Link extends WP_UnitTestCase {
$post_id = $this->factory->post->create();
$post_id2 = $this->factory->post->create();
$wp_rewrite->init();
$wp_rewrite->set_permalink_structure( '' );
$wp_rewrite->flush_rules();
// Basic case
$this->assertEquals( get_permalink( $post_id ), wp_get_shortlink( $post_id, 'post' ) );

8
tests/phpunit/tests/link/getNextCommentsLink.php
View File

@ -6,14 +6,6 @@
* @covers ::get_next_comments_link
*/
class Tests_Link_GetNextCommentsLink extends WP_UnitTestCase {
public function setUp() {
global $wp_rewrite;
parent::setUp();
$wp_rewrite->set_permalink_structure( '' );
$wp_rewrite->flush_rules();
}
public function test_page_should_respect_value_of_cpage_query_var() {
$p = $this->factory->post->create();

55
tests/phpunit/tests/link/getPostCommentsFeedLink.php
View File

@ -3,39 +3,8 @@
* @group link
*/
class Tests_Link_GetPostCommentsFeedLink extends WP_UnitTestCase {
private static $rewrite;
private static $permalink_structure;
static function setUpBeforeClass() {
global $wp_rewrite;
parent::setUpBeforeClass();
self::$rewrite = $wp_rewrite;
self::$permalink_structure = get_option( 'permalink_structure' );
}
public static function tearDownAfterClass() {
parent::tearDownAfterClass();
self::$rewrite->init();
self::$rewrite->set_permalink_structure( self::$permalink_structure );
self::$rewrite->flush_rules();
}
public function setUp() {
parent::setUp();
self::$rewrite->init();
}
private function set_permalink_structure( $structure ) {
self::$rewrite->set_permalink_structure( $structure );
self::$rewrite->flush_rules();
}
public function test_post_link() {
$this->set_permalink_structure( '' );
$post_id = $this->factory->post->create();
$link = get_post_comments_feed_link( $post_id );
@ -48,7 +17,10 @@ class Tests_Link_GetPostCommentsFeedLink extends WP_UnitTestCase {
}
public function test_post_pretty_link() {
$this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
global $wp_rewrite;
$wp_rewrite->init();
$wp_rewrite->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
$wp_rewrite->flush_rules();
$post_id = $this->factory->post->create();
@ -59,8 +31,6 @@ class Tests_Link_GetPostCommentsFeedLink extends WP_UnitTestCase {
}
public function test_attachment_link() {
$this->set_permalink_structure( '' );
$post_id = $this->factory->post->create();
$attachment_id = $this->factory->attachment->create_object( 'image.jpg', $post_id, array(
'post_mime_type' => 'image/jpeg',
@ -77,7 +47,10 @@ class Tests_Link_GetPostCommentsFeedLink extends WP_UnitTestCase {
}
public function test_attachment_pretty_link() {
$this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
global $wp_rewrite;
$wp_rewrite->init();
$wp_rewrite->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
$wp_rewrite->flush_rules();
$post_id = $this->factory->post->create( array(
'post_status' => 'publish'
@ -97,7 +70,10 @@ class Tests_Link_GetPostCommentsFeedLink extends WP_UnitTestCase {
}
public function test_attachment_no_name_pretty_link() {
$this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
global $wp_rewrite;
$wp_rewrite->init();
$wp_rewrite->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
$wp_rewrite->flush_rules();
$post_id = $this->factory->post->create();
$attachment_id = $this->factory->attachment->create_object( 'image.jpg', $post_id, array(
@ -112,8 +88,6 @@ class Tests_Link_GetPostCommentsFeedLink extends WP_UnitTestCase {
}
public function test_unattached_link() {
$this->set_permalink_structure( '' );
$attachment_id = $this->factory->attachment->create_object( 'image.jpg', 0, array(
'post_mime_type' => 'image/jpeg',
'post_type' => 'attachment'
@ -129,7 +103,10 @@ class Tests_Link_GetPostCommentsFeedLink extends WP_UnitTestCase {
}
public function test_unattached_pretty_link() {
$this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
global $wp_rewrite;
$wp_rewrite->init();
$wp_rewrite->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
$wp_rewrite->flush_rules();
$attachment_id = $this->factory->attachment->create_object( 'image.jpg', 0, array(
'post_mime_type' => 'image/jpeg',

8
tests/phpunit/tests/link/getPreviousCommentsLink.php
View File

@ -6,14 +6,6 @@
* @covers ::get_previous_comments_link
*/
class Tests_Link_GetPreviousCommentsLink extends WP_UnitTestCase {
public function setUp() {
global $wp_rewrite;
parent::setUp();
$wp_rewrite->set_permalink_structure( '' );
$wp_rewrite->flush_rules();
}
public function test_page_should_respect_value_of_cpage_query_var() {
$p = $this->factory->post->create();

4
tests/phpunit/tests/post.php
View File

@ -429,7 +429,7 @@ class Tests_Post extends WP_UnitTestCase {
$post = get_post( $p );
$wp_rewrite->set_permalink_structure( '' );
$this->reset_permalinks();
$this->assertEquals( "$p-2", $post->post_name );
}
@ -525,8 +525,6 @@ class Tests_Post extends WP_UnitTestCase {
// permalink should include the post ID at the end
$this->assertEquals(get_option('siteurl').'/2007/10/31/'.$id.'/', $plink);
$wp_rewrite->set_permalink_structure('');
}
/**

27
tests/phpunit/tests/post/wpUniquePostSlug.php
View File

@ -181,9 +181,6 @@ class Tests_Post_WpUniquePostSlug extends WP_UnitTestCase {
$found = wp_unique_post_slug( '2015', $p, 'publish', 'post', 0 );
$this->assertEquals( '2015-2', $found );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -203,9 +200,6 @@ class Tests_Post_WpUniquePostSlug extends WP_UnitTestCase {
$found = wp_unique_post_slug( '2015', $p, 'publish', 'post', 0 );
$this->assertEquals( '2015-2', $found );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -224,9 +218,6 @@ class Tests_Post_WpUniquePostSlug extends WP_UnitTestCase {
$found = wp_unique_post_slug( '2015', $p, 'publish', 'post', 0 );
$this->assertEquals( '2015', $found );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -245,9 +236,6 @@ class Tests_Post_WpUniquePostSlug extends WP_UnitTestCase {
$found = wp_unique_post_slug( '11', $p, 'publish', 'post', 0 );
$this->assertEquals( '11-2', $found );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -266,9 +254,6 @@ class Tests_Post_WpUniquePostSlug extends WP_UnitTestCase {
$found = wp_unique_post_slug( '11', $p, 'publish', 'post', 0 );
$this->assertEquals( '11', $found );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -287,9 +272,6 @@ class Tests_Post_WpUniquePostSlug extends WP_UnitTestCase {
$found = wp_unique_post_slug( '13', $p, 'publish', 'post', 0 );
$this->assertEquals( '13', $found );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -308,9 +290,6 @@ class Tests_Post_WpUniquePostSlug extends WP_UnitTestCase {
$found = wp_unique_post_slug( '30', $p, 'publish', 'post', 0 );
$this->assertEquals( '30-2', $found );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -329,9 +308,6 @@ class Tests_Post_WpUniquePostSlug extends WP_UnitTestCase {
$found = wp_unique_post_slug( '30', $p, 'publish', 'post', 0 );
$this->assertEquals( '30', $found );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
/**
@ -350,8 +326,5 @@ class Tests_Post_WpUniquePostSlug extends WP_UnitTestCase {
$found = wp_unique_post_slug( '32', $p, 'publish', 'post', 0 );
$this->assertEquals( '32', $found );
$wp_rewrite->set_permalink_structure( '' );
flush_rewrite_rules();
}
}

9
tests/phpunit/tests/query/results.php
View File

@ -683,12 +683,6 @@ class Tests_Query_Results extends WP_UnitTestCase {
* @ticket 29615
*/
function test_child_post_in_hierarchical_post_type_with_default_permalinks() {
global $wp_rewrite;
$old_permastruct = get_option( 'permalink_structure' );
$wp_rewrite->set_permalink_structure( '' );
$wp_rewrite->flush_rules();
register_post_type( 'handbook', array( 'hierarchical' => true ) );
$post_1 = $this->factory->post->create( array( 'post_title' => 'Contributing to the WordPress Codex', 'post_type' => 'handbook' ) );
@ -698,9 +692,6 @@ class Tests_Query_Results extends WP_UnitTestCase {
$result = $this->q->query( array( 'handbook' => 'contributing-to-the-wordpress-codex/getting-started', 'post_type' => 'handbook' ) );
$this->assertCount( 1, $result );
$wp_rewrite->set_permalink_structure( $old_permastruct );
$wp_rewrite->flush_rules();
}
function test_title() {

34
tests/phpunit/tests/rewrite/numericSlugs.php
View File

@ -47,8 +47,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
$this->go_to( get_permalink( '2015' ) );
$this->assertQueryTrue( 'is_single', 'is_singular' );
$wp_rewrite->set_permalink_structure('');
}
public function test_url_to_postid_year_segment_collision_without_title() {
@ -77,8 +75,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
);
$this->assertEquals( '2015', url_to_postid( get_permalink( '2015' ) ) );
$wp_rewrite->set_permalink_structure('');
}
public function test_go_to_year_segment_collision_with_title() {
@ -98,8 +94,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
$this->go_to( get_permalink( $id ) );
$this->assertQueryTrue( 'is_single', 'is_singular' );
$wp_rewrite->set_permalink_structure('');
}
public function test_url_to_postid_year_segment_collision_with_title() {
@ -117,8 +111,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
) );
$this->assertEquals( $id, url_to_postid( get_permalink( $id ) ) );
$wp_rewrite->set_permalink_structure('');
}
public function test_go_to_month_segment_collision_without_title() {
@ -139,8 +131,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
$this->go_to( get_permalink( $id ) );
$this->assertQueryTrue( 'is_single', 'is_singular' );
$wp_rewrite->set_permalink_structure('');
}
public function test_url_to_postid_month_segment_collision_without_title() {
@ -159,8 +149,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
) );
$this->assertEquals( $id, url_to_postid( get_permalink( $id ) ) );
$wp_rewrite->set_permalink_structure('');
}
public function test_go_to_month_segment_collision_without_title_no_leading_zero() {
@ -181,8 +169,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
$this->go_to( get_permalink( $id ) );
$this->assertQueryTrue( 'is_single', 'is_singular' );
$wp_rewrite->set_permalink_structure('');
}
public function test_url_to_postid_month_segment_collision_without_title_no_leading_zero() {
@ -201,8 +187,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
) );
$this->assertEquals( $id, url_to_postid( get_permalink( $id ) ) );
$wp_rewrite->set_permalink_structure('');
}
public function test_go_to_month_segment_collision_with_title() {
@ -222,8 +206,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
$this->go_to( get_permalink( $id ) );
$this->assertQueryTrue( 'is_single', 'is_singular' );
$wp_rewrite->set_permalink_structure('');
}
public function test_url_to_postid_month_segment_collision_with_title() {
@ -241,8 +223,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
) );
$this->assertEquals( $id, url_to_postid( get_permalink( $id ) ) );
$wp_rewrite->set_permalink_structure('');
}
public function test_go_to_month_segment_collision_with_title_no_leading_zero() {
@ -262,8 +242,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
$this->go_to( get_permalink( $id ) );
$this->assertQueryTrue( 'is_single', 'is_singular' );
$wp_rewrite->set_permalink_structure('');
}
public function test_url_to_postid_month_segment_collision_with_title_no_leading_zero() {
@ -281,8 +259,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
) );
$this->assertEquals( $id, url_to_postid( get_permalink( $id ) ) );
$wp_rewrite->set_permalink_structure('');
}
public function test_go_to_day_segment_collision_without_title() {
@ -303,8 +279,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
$this->go_to( get_permalink( $id ) );
$this->assertQueryTrue( 'is_single', 'is_singular' );
$wp_rewrite->set_permalink_structure('');
}
public function test_url_to_postid_day_segment_collision_without_title() {
@ -323,8 +297,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
) );
$this->assertEquals( $id, url_to_postid( get_permalink( $id ) ) );
$wp_rewrite->set_permalink_structure('');
}
public function test_go_to_day_segment_collision_with_title() {
@ -344,8 +316,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
$this->go_to( get_permalink( $id ) );
$this->assertQueryTrue( 'is_single', 'is_singular' );
$wp_rewrite->set_permalink_structure('');
}
public function test_url_to_postid_day_segment_collision_with_title() {
@ -363,8 +333,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
) );
$this->assertEquals( $id, url_to_postid( get_permalink( $id ) ) );
$wp_rewrite->set_permalink_structure('');
}
public function test_numeric_slug_permalink_conflicts_should_only_be_resolved_for_the_main_query() {
@ -389,8 +357,6 @@ class Tests_Rewrite_NumericSlugs extends WP_UnitTestCase {
$this->assertTrue( $q->is_day );
$this->assertFalse( $q->is_single );
$wp_rewrite->set_permalink_structure('');
}
public function test_month_slug_collision_should_resolve_to_date_archive_when_year_does_not_match_post_year() {

5
tests/phpunit/tests/rewrite/oldSlugRedirect.php
View File

@ -34,11 +34,6 @@ class Tests_Rewrite_OldSlugRedirect extends WP_UnitTestCase {
$this->old_slug_redirect_url = null;
remove_filter( 'old_slug_redirect_url', array( $this, 'filter_old_slug_redirect_url' ), 10 );
global $wp_rewrite;
$wp_rewrite->set_permalink_structure( '' );
$wp_rewrite->init();
}
public function test_old_slug_redirect() {

23
tests/phpunit/tests/term/getTermLink.php
View File

@ -4,28 +4,13 @@
* @group taxonomy
*/
class Tests_Term_GetTermLink extends WP_UnitTestCase {
private $permalink_structure;
public function setUp() {
parent::setUp();
// Assume no pretty permalinks.
global $wp_rewrite;
$this->permalink_structure = get_option( 'permalink_structure' );
$wp_rewrite->set_permalink_structure( '' );
$wp_rewrite->flush_rules();
register_taxonomy( 'wptests_tax', 'post' );
}
public function tearDown() {
global $wp_rewrite;
$wp_rewrite->set_permalink_structure( $this->permalink_structure );
$wp_rewrite->flush_rules();
parent::tearDown();
}
public function test_integer_should_be_interpreted_as_term_id() {
$t1 = $this->factory->term->create( array(
'taxonomy' => 'wptests_tax',
@ -101,7 +86,7 @@ class Tests_Term_GetTermLink extends WP_UnitTestCase {
public function test_taxonomy_permastruct_with_hierarchical_rewrite_should_put_term_ancestors_in_link() {
global $wp_rewrite;
$permalink_structure = get_option( 'permalink_structure' );
$wp_rewrite->init();
$wp_rewrite->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
$wp_rewrite->flush_rules();
@ -126,9 +111,6 @@ class Tests_Term_GetTermLink extends WP_UnitTestCase {
$actual = get_term_link( $t2, 'wptests_tax2' );
$wp_rewrite->set_permalink_structure( $permalink_structure );
$wp_rewrite->flush_rules();
$this->assertContains( '/foo/term1/term2/', $actual );
}
@ -159,9 +141,6 @@ class Tests_Term_GetTermLink extends WP_UnitTestCase {
$actual = get_term_link( $t2, 'wptests_tax2' );
$wp_rewrite->set_permalink_structure( $permalink_structure );
$wp_rewrite->flush_rules();
$this->assertContains( '/foo/term2/', $actual );
}
}

9
tests/phpunit/tests/user/author.php
View File

@ -15,11 +15,6 @@ class Tests_User_Author_Template extends WP_UnitTestCase {
function setUp() {
parent::setUp();
global $wp_rewrite;
$this->permalink_structure = get_option( 'permalink_structure' );
$wp_rewrite->set_permalink_structure( '' );
$wp_rewrite->flush_rules();
$this->author_id = $this->factory->user->create( array(
'role' => 'author',
'user_login' => 'test_author',
@ -42,10 +37,6 @@ class Tests_User_Author_Template extends WP_UnitTestCase {
}
function tearDown() {
global $wp_rewrite;
$wp_rewrite->set_permalink_structure( $this->permalink_structure );
$wp_rewrite->flush_rules();
wp_reset_postdata();
parent::tearDown();
}