sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Menus: Ensure theme location setting data is saved with a large menu. 

[36510] introduced a fix to allow users to save large menus on the Edit Menu screen (70+ menu items). The form data is stored as JSON which is used to inject the `$_POST` variable in the form submission handler. This injection was not setting form items with named array elements properly (e.g. `menu-locations[primary]`), which did not save theme location data in a large form.

Props keraweb.
See #14134.


git-svn-id: https://develop.svn.wordpress.org/trunk@36852 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Eric Andrew Lewis 2016-03-05 00:46:45 +00:00
parent 084772af80
commit ae1c49027a
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/wp-admin/nav-menus.php
View File

@ -51,18 +51,22 @@ $action = isset( $_REQUEST['action'] ) ? $_REQUEST['action'] : 'edit';
/* /*
* If a JSON blob of navigation menu data is found, expand it and inject it * If a JSON blob of navigation menu data is found, expand it and inject it
* into `$_POST` to avoid PHP `max_input_vars` limitations. See #14134. * into `$_POST` to avoid PHP `max_input_vars` limitations. See #14134.
*/ */
if ( isset( $_POST['nav-menu-data'] ) ) { if ( isset( $_POST['nav-menu-data'] ) ) {
$data = json_decode( stripslashes( $_POST['nav-menu-data'] ) ); $data = json_decode( stripslashes( $_POST['nav-menu-data'] ) );
if ( ! is_null( $data ) && $data ) { if ( ! is_null( $data ) && $data ) {
foreach ( $data as $post_input_data ) { foreach ( $data as $post_input_data ) {
// For input names that are arrays (e.g. `menu-item-db-id[3]`), derive the array path keys via regex. // For input names that are arrays (e.g. `menu-item-db-id[3]`), derive the array path keys via regex.
if ( preg_match( '#(.*)(?:\[(\d+)\])#', $post_input_data->name, $matches ) ) { if ( preg_match( '#(.*)\[(\w+)\]#', $post_input_data->name, $matches ) ) {
if ( empty( $_POST[ $matches[1] ] ) ) { if ( empty( $_POST[ $matches[1] ] ) ) {
$_POST[ $matches[1] ] = array(); $_POST[ $matches[1] ] = array();
} }
$_POST[ $matches[1] ][ (int) $matches[2] ] = wp_slash( $post_input_data->value ); // Cast input elements with a numeric array index to integers.
if ( is_numeric( $matches[2] ) ) {
$matches[2] = (int) $matches[2];
}
$_POST[ $matches[1] ][ $matches[2] ] = wp_slash( $post_input_data->value );
} else { } else {
$_POST[ $post_input_data->name ] = wp_slash( $post_input_data->value ); $_POST[ $post_input_data->name ] = wp_slash( $post_input_data->value );
} }