sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Site Health: Ensure the user locale is listed in debug information.

Browse Source 
This change switches to using `get_user_locale()` when adding the language to the Site Health debug information to ensure the user’s locale preference is reflected.

Also, `function_exists()` checks for `switch_to_locale()` and `restore_previous_locale()` were required in the plugin to support older versions of WordPress, but they are not required in core/

Props: Clorith, desrosj.
Fixes #46694.

git-svn-id: https://develop.svn.wordpress.org/trunk@45110 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jonathan Desrosiers 2019-04-04 21:23:29 +00:00
parent 0afc9b5119
commit af60a3c2bf
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/wp-admin/includes/class-wp-debug-data.php
View File

@ -34,11 +34,9 @@ class WP_Debug_Data {
global $wpdb; global $wpdb;
if ( ! empty( $locale ) ) { if ( ! empty( $locale ) ) {
// Change the language used for translations // Change the language used for translations
if ( function_exists( 'switch_to_locale' ) ) { $original_locale = get_user_locale();
$original_locale = get_locale();
$switched_locale = switch_to_locale( $locale ); $switched_locale = switch_to_locale( $locale );
} }
}
$upload_dir = wp_get_upload_dir(); $upload_dir = wp_get_upload_dir();
@ -73,7 +71,7 @@ class WP_Debug_Data {
), ),
'language' => array( 'language' => array(
'label' => __( 'Language' ), 'label' => __( 'Language' ),
'value' => ( ! empty( $locale ) ? $original_locale : get_locale() ), 'value' => ( ! empty( $locale ) ? $original_locale : get_user_locale() ),
), ),
'home_url' => array( 'home_url' => array(
'label' => __( 'Home URL' ), 'label' => __( 'Home URL' ),
@ -888,7 +886,7 @@ class WP_Debug_Data {
if ( ! empty( $locale ) ) { if ( ! empty( $locale ) ) {
// Change the language used for translations // Change the language used for translations
if ( function_exists( 'restore_previous_locale' ) && $switched_locale ) { if ( $switched_locale ) {
restore_previous_locale(); restore_previous_locale();
} }
} }

2
src/wp-admin/site-health-info.php
View File

@ -68,7 +68,7 @@ require_once( ABSPATH . 'wp-admin/admin-header.php' );
$info = WP_Debug_Data::debug_data(); $info = WP_Debug_Data::debug_data();
$english_info = ''; $english_info = '';
if ( 0 !== strpos( get_locale(), 'en' ) ) { if ( 0 !== strpos( get_user_locale(), 'en' ) ) {
$english_info = WP_Debug_Data::debug_data( 'en_US' ); $english_info = WP_Debug_Data::debug_data( 'en_US' );
} }
?> ?>